Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tokyocabinet - A modern implementation of a DBM https://bugzilla.redhat.com/show_bug.cgi?id=402141 ------- Additional Comments From dakingun@xxxxxxxxx 2007-11-28 10:22 EST ------- (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #2) > > > For 1.0.6-1: > > > > > > * location of header files > > > - I suggest to hide all header files under %_includedir/%name > > > (this also requires some fixes for installed header files and > > > .pc file). > > > > > May I ask why? > This is because this surely decreases the risk of the namespace conflict > of header files. Since there are just 3 of these header files with a rather 'distinct' name, I'll say we should just leave them in the default location. If any other package in the future will have the same name, then anyone putting them in should go the length of changing it namespace. (I've had a package where moving the header location from where upstream put it have caused issues.) version 1.0.8 files uploaded at; Spec URL: ftp://czar.eas.yorku.ca/pub/tokyocabinet/tokyocabinet.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/tokyocabinet/tokyocabinet-1.0.8-1.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review