[Bug 2029651] Review Request: python-frozenlist - List-like structure which can be made immutable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2029651



--- Comment #10 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
> Added a mention of the GitHub Makefile in a spec file comment next to the cython invocation

That settles it at least for me.

--------------


About the PYTHONPATH thing:


PYTHONPATH=${PWD}/build/lib.%{python3_platform}-%{python3_version} is a more
reliable value (it works on all architectures), but it requires pip with
in-tree builds, which is only happening on Fedora 36+ (pip 21.3+).

We could enable in-tree-build on Fedora 34/35 but I am afraid that it is not
very backward compatible. We might add an opt-in mechanism for packagers who
want to use this, though -- would that be helpful?

%{_pyproject_builddir} is mostly useless with in-tree build and once F35 goes
EOL, it will be deprecated but I'd keep it defined for EL9-compatibility.


(It worked on F34-F35 only because it was not required in the first place.)


As a side note, we might replace pip with build/install projects in the macro
implementations and this might all change a bit, but so would the direct pip
invocation.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2029651
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux