[Bug 2029651] Review Request: python-frozenlist - List-like structure which can be made immutable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2029651



--- Comment #8 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
It turns out that this package doesn’t use autodoc or anything similar, so it
doesn’t even import itself during the documentation build at all. I guess I
forgot to check that. So setting PYTHONPATH to build the documentation can be
dropped entirely, and I’ll update this package again to do that.

-----

For the general case, I tried

> PYTHONPATH='build/lib.linux-%{_arch}-%{python3_version}'

on another package awaiting review,
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2020886., and found that
it *almost* worked, so long as I formed an absolute path instead:

> PYTHONPATH="${PWD}:build/lib.linux-%{_arch}-%{python3_version}"

but it doesn’t quite work, because %{_arch} is i386 on x86, but the actual path
is build/lib.linux-i686-3.10, and similarly %{_arch} is arm on armv7hl, but the
actual path is build/lib.linux-armv7l-3.10. I now remember trying this and
running into the same problem in the past.

A heuristic approach, using a pattern to find the absolute path to the build
directory, does work on all architectures:

> PYTHONPATH="$(
>   find "${PWD}/build" -type d -name 'lib.linux-*-%{python3_version}' -print -quit
> )" %make_build -C docs latex SPHINXOPTS='%{?_smp_mflags}'

and maybe that’s the way to go. I don’t really like it, but I can live with it,
and it’s a bit simpler than the temporary install.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2029651
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux