https://bugzilla.redhat.com/show_bug.cgi?id=2029461 --- Comment #6 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- > Should we move it out of this package to nodejs-pacakging? Maybe. I’m not sure whether or not the idea of doing license validation at build time this way would be received with interest by the nodejs-packaging maintainers or by other packagers of NodeJS packages. (I think this is a small population. There seem to be only a handful of NodeJS packages overall right now.) Perhaps it’s worth pointing it out to the nodejs-packaging maintainers in the form of a heads-up: this script exists, and it solves certain problems for me. > Consider including %{?epoch:%{epoch}:}, it is helpful to avoid future mistakes. Sure, that’s reasonable. The epoch-less form is suggested in https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package, but adding the conditional epoch is obviously also correct. > Should %{buildroot}%{_prefix}/lib also be deleted after the move? Maybe, although it doesn’t really cause any harm: - It will end up getting re-created to hold the debuginfo files, which live in /usr/lib/debug%{_libdir} - It’s not included in any of the explicit %files lists. - If we missed moving a file, the build would fail due to unpackaged files Still, “rmdir %{buildroot}%{_prefix}/lib” would be harmless and could help document the expectation that we’ve emptied the directory at the time of the move. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2029461 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
