[Bug 2017119] Review Request: retry - Repeat a command until the command succeeds.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2017119



--- Comment #6 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> ---
The spec file looks really good now.

However, we still need to fix a couple of things that fedora-review
tool discovered. 

The checksum for the .tar.gz that you baked into your .src.rpm has a
different checksum than this file 
https://github.com/minfrin/retry/archive/retry-1.0.4/retry-1.0.4.tar.gz

    CHECKSUM(SHA256) this package     :
98abe614ef43fb31c99c7e941cddf3df0527361dc81be395066831eb6e1e7515
    CHECKSUM(SHA256) upstream package :
e7ab48923fd91aa2c5397cb2db4907a486176a582efe892a2113c9b91655f1e8

In fact, they are totally different tarballs. If you extract the SRPM
file using this command `rpm2cpio ./retry-1.0.4-1.fc36.src.rpm | cpio -i`
and explore the tarball, you can see that there are different files
than in the upstream tarball.

Rpmlint also discovered this

    retry.x86_64: W: incoherent-version-in-changelog 1.0.0-1 ['1.0.4-1.fc36',
'1.0.4-1']

Basically, your 1.0.4 version is not mentioned in the changelog.

Also, when you make updates to a specfile, don't forget to bump the
release number and add a new changelog entry :-)


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2017119
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux