https://bugzilla.redhat.com/show_bug.cgi?id=1938451 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(pemensik@redhat.c | |om) | --- Comment #15 from Petr Menšík <pemensik@xxxxxxxxxx> --- I think most of these changes do not affect linux builds at all. There are changes to astrometry, but most of them are changes made to enable compilation on WIN32 platform. Such changes are not important to us. I admit in current form bundled(astrometry) might be needed. But I think work to enable direct use of astrometry library should be done. I think it IS possible and no major changes would be required. But some would be. I think any changes needed should be proposed to astrometry project [1], which seems still active. I have not checked sep project [1] changes too much, but it seems active too. Its changes seems more heavy and unpatched upstream does not provide all required functionality. I would propose supplying also versions to Provides: bundled(astrometry) = 0.76 and comment current source is incompatible with existing package astrometry. Confirmed by upstream [2]. I think upstream maintainer might be able to provide also sep version [3], which were imported into stellarsolver library. It should be obvious they are much older than current versions. It should be noted both are modified and not compatible without additional work. I think some bug should be kept open to merge all required changes to astrometry.net directly, but they are not trivial enough to block whole review for them. Please fill a new review to finish inclusion. Expect I would request astrometry package reuse even for a passed package. But that might require multiple pull requests later. I guess we first want kstars to be updated and then can try improving its dependencies to reuse existing code. 1. https://github.com/dstndstn/astrometry.net 2. https://github.com/rlancaste/stellarsolver/issues/84#issuecomment-976086875 3. https://github.com/kbarbary/sep -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1938451 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
