https://bugzilla.redhat.com/show_bug.cgi?id=2023023 Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(dcavalca@xxxxxx) --- Comment #3 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> --- I think the rpmlint issues are fine (huh, fedora-review failed to parse them) Two issues that do need to be addressed, beyond that the package is fine: - license should be LGPLv2+ based on the actual headers - need to own %directory %_systemd_util_dir and %directory %_unitdir Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Library General Public License, Version 2.0", "*No copyright* GNU General Public License", "*No copyright* GNU Lesser General Public License", "GNU Library General Public License v2 or later [obsolete FSF postal address (Mass Ave)]", "FSF Unlimited License [generated file]", "Historical Permission Notice and Disclaimer - sell variant [generated file]", "GNU General Public License v2.0 or later [obsolete FSF postal address (Mass Ave)]", "GNU Lesser General Public License", "GNU Lesser General Public License v2.1 or later", "GNU General Public License v3.0 or later", "FSF All Permissive License", "*No copyright* The Unlicense", "GNU Library General Public License v2 or later", "Mozilla Public License 1.0", "BSD-4-Clause (University of California-Specific)", "Mozilla Public License 1.0 Common Public License 1.0". 272 files have unknown license. Detailed output of licensecheck in /home/michel/src/fedora/reviews/2023023-regina-rexx/licensecheck.txt Per "grep -r 'version 2 of the License' *" you probably want LGPLv2+ [x]: License file installed when any subpackage combination is installed. note: you can drop it from devel as devel depends on libs [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/systemd, /usr/lib/systemd/system you probably want to either own these or pull in systemd. If the service file is optional, just own the directories using %directory %_systemd_util_dir and %directory %_unitdir [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 184320 bytes in 42 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in regina-rexx [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in regina- rexx-devel , regina-rexx-libs [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Unversioned so-files -------------------- regina-rexx-libs: /usr/lib64/regina-rexx/addons/libregutil.so regina-rexx-libs: /usr/lib64/regina-rexx/addons/librxtest1.so regina-rexx-libs: /usr/lib64/regina-rexx/addons/librxtest2.so Source checksums ---------------- https://sourceforge.net/projects/regina-rexx/files/regina-rexx/3.9.4/regina-rexx-3.9.4.tar.gz : CHECKSUM(SHA256) this package : 64f9afdf9bbf7280cffd9efc1ca25cadf6dc59467452cba467aa63cef1815fa4 CHECKSUM(SHA256) upstream package : 64f9afdf9bbf7280cffd9efc1ca25cadf6dc59467452cba467aa63cef1815fa4 Requires -------- regina-rexx (rpmlib, GLIBC filtered): /bin/sh libc.so.6()(64bit) libcrypt.so.2()(64bit) libcrypt.so.2(XCRYPT_2.0)(64bit) libregina.so.3()(64bit) libregina.so.3(regina_2.0)(64bit) regina-rexx-libs(x86-64) rtld(GNU_HASH) regina-rexx-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config /usr/bin/sh libregina.so.3()(64bit) regina-rexx-libs(x86-64) regina-rexx-libs (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypt.so.2()(64bit) libcrypt.so.2(XCRYPT_2.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libreadline.so.8()(64bit) libregina.so.3()(64bit) libregina.so.3(REXXSAA_API)(64bit) libregina.so.3(regina_2.2)(64bit) libtinfo.so.6()(64bit) rtld(GNU_HASH) regina-rexx-doc (rpmlib, GLIBC filtered): regina-rexx-debuginfo (rpmlib, GLIBC filtered): regina-rexx-debugsource (rpmlib, GLIBC filtered): Provides -------- regina-rexx: regina-rexx regina-rexx(x86-64) regina-rexx-devel: pkgconfig(libregina) regina-rexx-devel regina-rexx-devel(x86-64) regina-rexx-libs: libregina.so.3()(64bit) libregina.so.3(REXXSAA_API)(64bit) libregina.so.3(regina_2.0)(64bit) libregina.so.3(regina_2.2)(64bit) libregina.so.3(regina_3.1)(64bit) libregina.so.3(regina_3.3)(64bit) libregina.so.3(regina_3.7)(64bit) libregutil.so()(64bit) librxtest1.so()(64bit) librxtest2.so()(64bit) regina-rexx-libs regina-rexx-libs(x86-64) regina-rexx-doc: regina-rexx-doc regina-rexx-debuginfo: debuginfo(build-id) regina-rexx-debuginfo regina-rexx-debuginfo(x86-64) regina-rexx-debugsource: regina-rexx-debugsource regina-rexx-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2023023 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Java, Ocaml, Perl, SugarActivity, Haskell, Python, PHP, fonts, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2023023 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
