https://bugzilla.redhat.com/show_bug.cgi?id=2027417 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Hi, I'm the main Rust package maintainer in Fedora, I'll leave some inline comments here. >1. Currently doesn't build because 3 dependencies are not available in yum repos (these packages have been approved, and scm requests have been filed, bzs are listed as blockers to this bug) You can use "mock --chain" to build multiple packages after one another. You only need to feed it the SRPM files of everything that's not available from repositories yet in the correct order. That way you can at least have a local mockbuild. >2. rust-netavark will only be an application crate and a leaf package as far as rust dependencies are concerned. So, we don't need it to be published as a crate to approve it. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_package_sources Correct, application-only crates do not need to be published on crates.io to be packaged. However, in that case, the source package also MUST NOT use the "rust-" prefix, because that namespace is reserved for crates from the crates.io. >3. rpmlint is happy on the spec file >4. License is correct and valid Since this is a package that contains statically linked code with various licenses, you will need to query all dependencies for their licenses and determine the effective license of the built binary. You can run $ dnf repoquery --cacheonly "rust-*-devel" --installed --qf "# %{LICENSE}: %{source_name} %{version}" in the mock chroot ($ mock shell), it will print all installed Rust dependencies and their licenses, which you can then paste into the .spec file above the "License: Foo and Bar and (Baz or Fop)" tag in the subpackage that contains the built binary. >5. Only the application is packaged, no libraries packaged. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2027417 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
