[Bug 2022208] Review Request: rust-unic-langid-impl - API for managing Unicode Language Identifiers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2022208

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |decathorpe@xxxxxxxxx



--- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
Sorry for the noise, but for completeness, I accidentally commented with some
issues in this package on the wrong review request:
https://bugzilla.redhat.com/show_bug.cgi?id=2022205#c5

TL;DR: This package *does* contain binaries (and it shouldn't), overriding
double-underscored-macros like __cargo_skip_build is a bad idea (those are not
meant to be set in .spec files), and the macro was removed with rust2rpm 20.
Please use an alternative method of disabling those binaries (as outlined in
the linked comment).


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2022208
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux