https://bugzilla.redhat.com/show_bug.cgi?id=2022205 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > - only sources installed This is not true. The package installs two binaries (even though it was "turned off" by setting a dunder-macro). Just overriding __cargo_skip_build is the wrong thing to do here (as is overriding double-underscored-macros, in general), because that also makes the package noarch, where it shouldn't be, so tests only run on one architecture at a time, etc. Additionally, this unconventional use of "__cargo_skip_build 1" is now broken, because that macro was under no circumstances set to 1 since Fedora 31 or so (it was only ever set to 1 in module builds, and it's been a long while since those were a thing for Rust). Since it looks like those binaries are only used for upstream development, I suggest to drop them from the .spec file entirely to prevent future issues like this. You can look at https://src.fedoraproject.org/rpms/rust-protobuf-codegen-pure/tree/rawhide for an example how to do that relatively easily (rust2rpm will not even generate the subpackages related to binaries if you do it like this). Another way to do this (that's not as nice) is to set the __cargo_is_bin() macro to 0 and drop the generated binary subpackage manually, like in cargo: https://src.fedoraproject.org/rpms/rust-cargo/blob/rawhide/f/rust-cargo.spec But the first solution (small patch to disable building the binaries) is a cleaner solution, as that also automatically adapts the generated .spec file. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2022205 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
