Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pyJigdo - Python Based Jigdo https://bugzilla.redhat.com/show_bug.cgi?id=395051 s.adam@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |s.adam@xxxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From s.adam@xxxxxxxxxxxx 2007-11-27 18:29 EST ------- + source files match upstream: fc54cbb4e0df8df21d48ee2b00680a6c3124f0a2 + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. GPLv2 License text included in package. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package installs properly debuginfo package looks complete. - rpmlint is silent. * Two minor errors: pyjigdo.src: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 5) pyjigdo.src: W: strange-permission pyjigdo.spec 0600 pyjigdo.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/pyjigdo/__init__.py 0644 pyjigdo.noarch: E: zero-length /usr/share/doc/pyjigdo-0.2/NEWS pyjigdo.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/pyjigdo-0.2/TODO pyjigdo.noarch: E: zero-length /usr/share/doc/pyjigdo-0.2/AUTHORS pyjigdo.noarch: W: incoherent-version-in-changelog 0.2-2 0.2-2.20071127git.fc8 + final provides are sane: config(pyjigdo) = 0.2-2.20071127git.fc8 pyjigdo = 0.2-2.20071127git.fc8 + final requires are sane: /usr/bin/python config(pyjigdo) = 0.2-2.20071127git.fc8 jigdo python(abi) = 2.5 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. A Koji (scratch) build is in progress here: http://koji.fedoraproject.org/koji/taskinfo?taskID=262420 Assuming that completes successfully, just the few changes to fix the rpmlint messages are needed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review