https://bugzilla.redhat.com/show_bug.cgi?id=2025155 --- Comment #1 from Petr Menšík <pemensik@xxxxxxxxxx> --- Few notes when looking on spec file: 1) Patch0 should ideally link to change proposed to upstream and contain link to upstream issue in a comment. Of course the change should be a bit modified then. 2) %ctest should be used if possible in %check 3) ctest does not seem to support test suite used by the project. Either propose upstream fix to find tests under ctest. Or use %cmake_build -t check to run test suite. If it needs network connectivity, use %bcond_with check and if %{with check}. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2025155 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
