https://bugzilla.redhat.com/show_bug.cgi?id=2020883 Maxwell G <gotmax@e.email> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(thunderbirdtr@fed | |oraproject.org) --- Comment #16 from Maxwell G <gotmax@e.email> --- Hi Onuralp, We are almost there; there are just a couple minor issues left. (In reply to Maxwell G from comment #9) > You should also add `BuildRequires: cmake(KF5DBusAddons)`[3] to be explicit. > > [3]: https://invent.kde.org/pim/kalendar/-/compare/v0.1.0...v0.2.1?from_project_id=7106#9a2aa4db38d3115ed60da621e012c0efc0172aae This still needs to be fixed. > %check > desktop-file-validate %{buildroot}%{_datadir}/applications/org.kde.%{name}.desktop > appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/org.kde.%{name}.appdata.xml According to the KDE SIG,`%{_kf5_*}` macros should be used for KDE applications[1,2]. In your case, you should use `%{_kf5_datadir}` instead of `%{_datadir}` and `%{_kf5_metainfodir}` instead of `%{_metainfodir}`. For the aforementioned macros, the kf5 variants actually have the same values as the non kf5 variants in Fedora, but the kf5 macros are still preferred. Also, you should remain consistent; don't use `%{_datadir}` in one part of the spec and `%{_kf5_datadir}` in another. Admittedly, this is an unimportant change, but I don't think it requires much effort to implement, so we should do so. Thanks, Maxwell [1]: https://lists.fedoraproject.org/archives/list/kde@xxxxxxxxxxxxxxxxxxxxxxx/thread/ZPZTD4F77OICVSPIL7BL22GGQXWQM7PL/ [2]: https://lists.fedoraproject.org/archives/list/kde@xxxxxxxxxxxxxxxxxxxxxxx/thread/A4B7MUWO3QYKNA26V2FIEP73C4RT6IJU/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2020883 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
