https://bugzilla.redhat.com/show_bug.cgi?id=2020883 Onuralp SEZER <thunderbirdtr@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(thunderbirdtr@fed | |oraproject.org) | --- Comment #13 from Onuralp SEZER <thunderbirdtr@xxxxxxxxxxxxxxxxx> --- (In reply to Maxwell G from comment #12) > Hi Onuralp, > > I have a couple more pointers. I will approve your package once everything > is fixed. In retrospect, I should have done that in the first place. > > (In reply to Maxwell G from comment #11) > > [!]: Package must own all directories that it creates. > > Note: Directories without known owners: > > /usr/share/icons/hicolor/scalable, > > /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor > > > > I think you should add 'Requires: hicolor-icon-theme`. Admittedly, I'm not super sure about this issue. I added hicolor-icon-theme instead of owning (easier and cleaner) > I confirmed that you need to own those icon directories. One option is to > add `Requires: hicolor-icon-theme`. You can alternatively put `%dir > $unowned_directory` in the `%files` section for each of the unowned > directories. I prefer the former, but both solutions are valid. > > > appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/org.kde.%{name}.appdata.xml > > > %files -f %{name}.lang > > [...] > > %{_kf5_datadir}/metainfo/org.kde.kalendar.appdata.xml > > [...] kf5_metainfodir done > You should use %{_kf5_metainfodir}[1] instead of `%{_metainfodir}` or > `%{_kf5_datadir}/metainfo`. I'm gonna keep it > > License: GPLv3+ > > I don't think this is required, but I recommend adding a comment above the > `License` field in your specfile linking to or paraphrasing my previous > comment about licensing[2] to avoid any confusion down the line. > > Thanks, > Maxwell > > [1]: https://src.fedoraproject.org/rpms/kf5/blob/rawhide/f/macros.kf5#_9 > [2]: https://bugzilla.redhat.com/show_bug.cgi?id=2020883#c1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2020883 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
