https://bugzilla.redhat.com/show_bug.cgi?id=2019686 --- Comment #9 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Looks very good, *almost* there :) - BuildRequires: numpy -> BuildRequires: python3-numpy This is because we want to be specific about that we need here. - %py3_check_import nrrd -> %py3_check_import I learned in one of my package reviews that there's no need to specify the module name here.. It will automatically check all the modules that `pyproject_save_files` macro finds. if we specify one, it'll *only* check for the one instead, so we shouldn't do that. Here's the guideline: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_test_macros Once these tweaks are made, this package will be ready for approval :) Cheers, Ankur -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2019686 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
