https://bugzilla.redhat.com/show_bug.cgi?id=2026815 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx CC| |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Package looks good to me, with one flaw from the upstream project ... Both the LICENSE and the README.md file are implicitly excluded from published crates: https://github.com/Voultapher/self_cell/blob/main/Cargo.toml#L16 Please open an issue or PR with upstream to explicitly include at least the LICENSE file. The terms of the Apache-2.0 license require redistributed sources to contain the license text. You can either wait until this is rectified in a new upstream release, or include the LICENSE file from github manually, until the first one happens: https://github.com/Voultapher/self_cell/blob/v0.10.1/LICENSE Either of those is acceptable here, and I'll finish the review once either are done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2026815 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
