[Bug 2010718] Review Request: alizams - A DICOM viewer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2010718

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+



--- Comment #31 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
%description
→ wrap to <=80 columns.
Maybe after "de-identify" add "(remove personal information)" or something. The
term might not
be obvious to most people.

+ package name is OK
+ latest version 
+ license is acceptable for Fedora (GPLv3)
+ license is specified correctly
+ BR/R/P look OK
+ %check is present and passes (though very minimalistic…)
+ build and installs and runs OK

rpmlint:
alizams.src:34: W: unversioned-explicit-provides bundled(vectormath)
alizams.src:35: W: unversioned-explicit-provides bundled(colorspace)
This is OK: in principle the guidelines say that a version should be provided,
but
figuring this out is onerous and often the exact version cannot be determined.
And
when the bundled code has been modified, as is the case here, no number would
make sense.
alizams.src: W: spelling-error Summary(en_US) Aliza -> Alissa, Alisa, Eliza
alizams.src: W: spelling-error %description -l en_US de -> DE, ed, d
alizams.x86_64: W: spelling-error Summary(en_US) Aliza -> Alissa, Alisa, Eliza
alizams.x86_64: W: spelling-error %description -l en_US de -> DE, ed, d
4 packages and 0 specfiles checked; 0 errors, 6 warnings.
All good.

Package is APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2010718
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux