Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ovaldi - Reference implementation of the OVAL interpreter Alias: ovaldi-review https://bugzilla.redhat.com/show_bug.cgi?id=399521 mmahut@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From mmahut@xxxxxxxxxx 2007-11-27 16:29 EST ------- + package builds in mock (koji 262041). + rpmlint is reasonable for SRPM and for RPM. + source files match upstream. 5af68d5e0b8f51891b23a52f019741e8 interpreters.src-5.3.tbz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in good english. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible (BSD). + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Package contains contents. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review