https://bugzilla.redhat.com/show_bug.cgi?id=2025751 David Cantrell <dcantrell@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(rharwood@redhat.c | |om) --- Comment #4 from David Cantrell <dcantrell@xxxxxxxxxx> --- Things I noticed on review: * [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libptytty-devel The %{?_isa} part was missing from the Requires on the devel package. * [!]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. Upstream appears to have a .sig file, so this package could probably do the gpgverify thing. * libptytty.x86_64: E: missing-call-to-setgroups-before-setuid /usr/lib64/libptytty.so.0 This may be an rpmlint error. I don't understand what it's telling me here. And not required, but kind of convention... Changes and README could go in %doc -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2025751 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
