https://bugzilla.redhat.com/show_bug.cgi?id=2023061 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #17 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- + package name is OK + license is acceptable (MIT) + license is specified correctly + latest version + builds and installs correctly - %check is missing, see suggestion below + BR/R/P look OK + fedora-review finds no issues rpmlint: libdeflate.src: W: spelling-error Summary(en_US) gzip -> zip, grip, g zip libdeflate.src: W: spelling-error Summary(en_US) zlib -> lib, glib, z lib libdeflate.src: W: spelling-error %description -l en_US gzip -> zip, grip, g zip libdeflate.src: W: spelling-error %description -l en_US zlib -> lib, glib, z lib libdeflate.src:57: W: macro-in-%changelog %autochangelog libdeflate.x86_64: W: spelling-error Summary(en_US) gzip -> zip, grip, g zip libdeflate.x86_64: W: spelling-error Summary(en_US) zlib -> lib, glib, z lib libdeflate.x86_64: W: spelling-error %description -l en_US gzip -> zip, grip, g zip libdeflate.x86_64: W: spelling-error %description -l en_US zlib -> lib, glib, z lib libdeflate-devel.x86_64: W: no-documentation libdeflate-utils.x86_64: W: no-documentation libdeflate-utils.x86_64: W: no-manual-page-for-binary libdeflate-gunzip libdeflate-utils.x86_64: W: no-manual-page-for-binary libdeflate-gzip 7 packages and 0 specfiles checked; 0 errors, 13 warnings. All OK. This is from rpmlint-1.11-19.fc33.noarch. Newer rpmlint has some additional (bogus) complaints. Package is APPROVED. I think it's be nice to add something like this: %check %{buildroot}%{_bindir}/libdeflate-gzip -c %{buildroot}%{_bindir}/libdeflate-gzip >gzip.gz %{buildroot}%{_bindir}/libdeflate-gzip -t gzip.gz %{buildroot}%{_bindir}/libdeflate-gunzip -c gzip.gz >gzip.gz.unzipped diff %{buildroot}%{_bindir}/libdeflate-gzip gzip.gz.unzipped to catch trivial build issues. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2023061 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
