https://bugzilla.redhat.com/show_bug.cgi?id=2019157 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@xxxxxxxxx Flags| |fedora-review+ Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx --- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > License: BSD and (BSD and ISC) You can simplify this to just "BSD". ISC is explicitly the same as BSD but with a few terms removed. So to satisfy both BSD and ISC you need to satisfy exactly BSD. And the License field is the effective license [https://fedoraproject.org/wiki/Licensing:FAQ#What_is_.22effective_license.22_and_do_I_need_to_know_that_for_the_License:_tag.3F]. > BuildRequires: %{py3_dist pytest} Nowadays we mostly write 'python3dist(pytest)'… + package name is OK + latest version + license is acceptable (effectively BSD-3-clause) - license is specified correctly: see above + builds and installs OK + %check is present and passes + BR/R/P look OK rpmlint: python3-pyct.noarch: W: spelling-error %description -l en_US cmd -> cm, cad, cod python3-pyct.noarch: W: spelling-error %description -l en_US subcommands -> sub commands, sub-commands, commands Bogus. python3-pyct.noarch: W: hidden-file-or-dir /usr/lib/python3.10/site-packages/pyct/.version Upstream "design choice" python3-pyct+build.noarch: W: spelling-error Summary(en_US) Metapackage -> Meta package, Meta-package, Prepackage python3-pyct+build.noarch: W: spelling-error Summary(en_US) pyct -> pct, pact python3-pyct+build.noarch: W: spelling-error %description -l en_US metapackage -> meta package, meta-package, prepackage python3-pyct+build.noarch: W: spelling-error %description -l en_US pyct -> pct, pact python3-pyct+cmd.noarch: W: spelling-error Summary(en_US) Metapackage -> Meta package, Meta-package, Prepackage python3-pyct+cmd.noarch: W: spelling-error Summary(en_US) pyct -> pct, pact python3-pyct+cmd.noarch: W: spelling-error Summary(en_US) cmd -> cm, cad, cod python3-pyct+cmd.noarch: W: spelling-error %description -l en_US metapackage -> meta package, meta-package, prepackage python3-pyct+cmd.noarch: W: spelling-error %description -l en_US cmd -> cm, cad, cod python3-pyct+cmd.noarch: W: spelling-error %description -l en_US pyct -> pct, pact python-pyct.src: W: spelling-error %description -l en_US cmd -> cm, cad, cod python-pyct.src: W: spelling-error %description -l en_US subcommands -> sub commands, sub-commands, commands I wish rpmlint would be smart enough to filter out the package name from spelling reports, alas. python3-pyct+build.noarch: W: no-documentation python3-pyct+cmd.noarch: W: no-documentation python-pyct.src:55: W: unversioned-explicit-provides bundled(python3dist(clint)) python-pyct.src:130: W: macro-in-%changelog %autochangelog 4 packages and 0 specfiles checked; 0 errors, 19 warnings. All bogus too. Package is APPROVED. Please fix the License field when importing. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2019157 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
