[Bug 2023061] Review Request: libdeflate - Fast implementation of DEFLATE, zlib, and gzip

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2023061



--- Comment #15 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
> You had PREFIX=%{_prefix} in the build line and PREFIX=/usr in the install line. I assume you meant the former in both cases.
Oh, good catch.

> -fPIC -fpie -pie stuff on the binaries:
Yeah, it seems that the pie flags should be added back where they were.

Most of the rpmlint warnings are bogus:
> libdeflate-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz
> libdeflate-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz
All debuginfo packages seem to have that.

> libdeflate.x86_64: E: shlib-policy-name-error 0
This is printed for various libs, and it seems to be just an error / stupid
default configuration in rpmlint.

> libdeflate-devel.x86_64: W: missing-dependency-on libdeflate*/libdeflate-libs/liblibdeflate* = 1.8
The -devel package has Requires:libdeflate(x86-64) = 1.8-3.fc36, so that seems
invalid too.

> libdeflate.spec:57: W: macro-in-%changelog %autochangelog
Bogus obviously.

> libdeflate-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/bb/c2ce132fcddce4617bdf4b5bd2c922f6db65a9 ../../../.build-id/bb/c2ce132fcddce4617bdf4b5bd2c922f6db65a9
> libdeflate-utils-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/45/c5cea781642cd8998677a25ffdda2d5582e459 ../../../.build-id/45/c5cea781642cd8998677a25ffdda2d5582e459
> libdeflate-utils-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/45/c5cea781642cd8998677a25ffdda2d5582e459.1 ../../../.build-id/45/c5cea781642cd8998677a25ffdda2d5582e459.1

rpmlint doesn't understand the split into -debugsource packages...


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2023061
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux