[Bug 2010718] Review Request: alizams - A DICOM viewer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2010718



--- Comment #19 from issakomi <mihail.isakov@xxxxxxxxx> ---
> bullet: there is a package. I think it should be possible to BR:bullet-devel and use the system lib.

Done. There is the option ALIZA_USE_SYSTEM_BULLET.
S.
https://raw.githubusercontent.com/AlizaMedicalImaging/AlizaMS/master/fedora-34/alizams.spec
for SPEC template.

> It'd be great to remove as much of the unused sources as possible in %prep.
It works.
rm -fr mdcm/Utilities/mdcmzlib/
rm -fr mdcm/Utilities/mdcmopenjpeg/
rm -fr mdcm/Utilities/mdcmcharls/
rm -fr mdcm/Utilities/mdcmuuid/
rm -fr mdcm/Utilities/pvrg/
rm -fr b/
rm -fr CG/glew/
S. %prep section (link above)

> think that for those three it would be reasonable to add Provides: bundled(vectormath), etc.

Vectormath is header-only.
MDCM is purposely part of AlizaMS. Maybe it will be released as library later,
not yet sure.
Colorspace is slightly modified, turned into C++ pure static class. So even if
somebody will package
https://getreuer.info/posts/colorspace/index.html
it will not work. It is one .h and one .cpp file, easier to add to source.

Version is 1.7.2 now.


Thank you very much!

P.S. There was a very minor issue in alizams.appdata.xml in screenshot section
in latest rpm. My suggestion would be

  <screenshots>
    <screenshot type="default">
     
<image>https://raw.githubusercontent.com/AlizaMedicalImaging/AlizaMS/master/package/art/alizams_scr1.jpg</image>
    </screenshot>
    <screenshot>
     
<image>https://raw.githubusercontent.com/AlizaMedicalImaging/AlizaMS/master/package/art/alizams_scr2.jpg</image>
    </screenshot>
  </screenshots>


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2010718
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux