https://bugzilla.redhat.com/show_bug.cgi?id=2023061 --- Comment #11 from Nick Black <dank@xxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #10) > That's a strange one. I've never seen this message before. Are you using a > non-Fedora version of rpmlint? i hope not? > Fedora does not name packages after so-versions, please rename it back. done. > > %define debug_package %{nil} > > This is wrong, we need debuginfo. > > > CFLAGS="-fpic -pie -g" > > This is also wrong. Packages must use standard compilation flags as provided > by the macros. > [https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags] > > > %{__strip} > > General rule: do not use double-underscore-prefixed commands. Those were > popular back in the day, > but they are useless and the guidelines finally have been changed to > discourage them. > > Specific rule: strip is called on all binaries through > /usr/lib/rpm/redhat/brp-strip-lto, > so we need to figure out why that call doesn't work, and fix the compilation > process so that > it does. > ... > Oh, it turns out that that this is the typical case of "upstream invents own > build system, the > result is 90% correct". Please see the attached patch. Applied. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2023061 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
