https://bugzilla.redhat.com/show_bug.cgi?id=2010718 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx --- Comment #14 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > %global github_name AlizaMS The usual comment: if you really want to, this is allowed. But to me it makes no sense to use such pointless macros. They make the spec file harder to read, longer (!), and also break select-and-paste-and-use and/or ctrl-click-to-open. > %description > A DICOM viewer. Very fast directory scanner, DICOMDIR. 2D and 3D views with > many tools. View uniform and non-uniform series in physical space. > Consistently de-identify DICOM. View DICOM metadata. Ultrasound with proper > measurement in regions, cine. Scout (localizer) lines. Grayscale softcopy > presentation. Structured report. Compressed images. RTSTRUCT contours. > Siemens mosaic format. United Imaging Healthcare (UIH) Grid / VFrame format. > Elscint ELSCINT1 PMSCT_RLE1 and PMSCT_RGB1 That reads like a bullet list compressed into paragraph format. Maybe try to make it a bit more like a normal text? Also there's a list of formats at the end, I'm not sure what it means. > # Install appdata > install -d %{buildroot}%{_datadir}/metainfo > install -p -m 0644 %{SOURCE1} \ > %{buildroot}%{_datadir}/metainfo install -Dpt %{buildroot}%{_datadir}/metainfo/ -m 0644 %{SOURCE1} In %check, it'd be nice to at least call the installed binaries to see if the execute correctly. -- Mikhail, thank you for the comment about licensing. > Many of them are not used, because build for the distribution uses system's libraries, e.g. CharLS, OpenJPEG, Zlib, etc. GLEW is used with only with Qt4. It'd be great to remove as much of the unused sources as possible in %prep. This way it'll be clearer what is used (and what we need to look at). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2010718 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
