https://bugzilla.redhat.com/show_bug.cgi?id=2010111 --- Comment #4 from Sandro Mani <manisandro@xxxxxxxxx> --- There is a godot package in fedora, can it be used rather then the separate sources? If not: * You could set a macro %global godot_ver 3.4 and use it for the source URLs and in %setup. The source URLs could be simplified to Source1: https://github.com/godotengine/godot-cpp/archive/godot-%{godot_ver}-stable/godot-cpp-%{godot_ver}-stable.tar.gz Source2: https://github.com/godotengine/godot-headers/archive/godot-%{godot_ver}-stable/godot-headers-%{godot_ver}-stable.tar.gz * The license should be zlib and MIT, as godot-cpp and headers is MIT, and include the godot LICENSE files in %license * You'll need to add Provides: bundled(godot) = %{godot_ver} Furthermore, you could replace mkdir -p %{buildroot}%{_libdir} cp %{name}-%{version}/bin/x11/libgdgamerzilla.so %{buildroot}%{_libdir}/libgdgamerzilla.so with install -Dpm 0755 %{name}-%{version}/bin/x11/libgdgamerzilla.so %{buildroot}%{_libdir}/libgdgamerzilla.so -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2010111 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
