https://bugzilla.redhat.com/show_bug.cgi?id=2024130 --- Comment #1 from Dennis Payne <dulsi@xxxxxxxxxxxxxxxxxxxxx> --- Fedora-review complained about naming but it should match the non mingw packages so that is fine. The one issue I see is that the tools packages need the license just in case you install only those packages. Alternatively do we even need these packages. You need the libraries to cross-compile but the windows tools are probably not going to be used. I left the issue about directories. I don't know if this is something that needs to be fixed. Shouldn't other mingw packages have the same problem? Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= [!]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/debug/usr/i686-w64-mingw32/sys- root/mingw/bin, /usr/lib/debug/usr/i686-w64-mingw32, /usr/lib/debug/usr/x86_64-w64-mingw32/sys-root, /usr/lib/debug/usr/x86_64-w64-mingw32/sys- root/mingw/bin/osgPlugins-3.6.5, /usr/lib/debug/usr/x86_64-w64-mingw32/sys-root/mingw, /usr/lib/debug/usr/x86_64-w64-mingw32/sys-root/mingw/bin, /usr/lib/debug/usr/i686-w64-mingw32/sys-root, /usr/lib/debug/usr/i686-w64-mingw32/sys-root/mingw, /usr/lib/debug/usr/i686-w64-mingw32/sys- root/mingw/bin/osgPlugins-3.6.5, /usr/lib/debug/usr/x86_64-w64-mingw32 [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/debug/usr/x86_64-w64-mingw32/sys-root/mingw, /usr/lib/debug/usr/x86_64-w64-mingw32/sys- root/mingw/bin/osgPlugins-3.6.5, /usr/lib/debug/usr/x86_64-w64-mingw32/sys-root/mingw/bin, /usr/lib/debug/usr/i686-w64-mingw32/sys-root, /usr/lib/debug/usr/i686-w64-mingw32/sys- root/mingw/bin/osgPlugins-3.6.5, /usr/lib/debug/usr/i686-w64-mingw32/sys-root/mingw/bin, /usr/lib/debug/usr/x86_64-w64-mingw32, /usr/lib/debug/usr/i686-w64-mingw32, /usr/lib/debug/usr/x86_64-w64-mingw32/sys-root, /usr/lib/debug/usr/i686-w64-mingw32/sys-root/mingw ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. This is same license as the OpenSceneGraph package. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mingw32-OpenSceneGraph , mingw64-OpenSceneGraph , mingw32-OpenSceneGraph-tools , mingw64-OpenSceneGraph-tools [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: The placement of pkgconfig(.pc) files are correct. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/openscenegraph/OpenSceneGraph/archive/OpenSceneGraph-3.6.5/OpenSceneGraph-3.6.5.tar.gz : CHECKSUM(SHA256) this package : aea196550f02974d6d09291c5d83b51ca6a03b3767e234a8c0e21322927d1e12 CHECKSUM(SHA256) upstream package : aea196550f02974d6d09291c5d83b51ca6a03b3767e234a8c0e21322927d1e12 Requires -------- mingw32-OpenSceneGraph (rpmlib, GLIBC filtered): mingw32(gdi32.dll) mingw32(kernel32.dll) mingw32(libcairo-2.dll) mingw32(libcurl-4.dll) mingw32(libfontconfig-1.dll) mingw32(libfreetype-6.dll) mingw32(libgcc_s_dw2-1.dll) mingw32(libgdal-30.dll) mingw32(libgif-7.dll) mingw32(libgobject-2.0-0.dll) mingw32(libgta-1.dll) mingw32(libimath-3_1.dll) mingw32(libjasper-4.dll) mingw32(libjpeg-62.dll) mingw32(libopenexr-3_1.dll) mingw32(libopenthreads.dll) mingw32(libosg.dll) mingw32(libosganimation.dll) mingw32(libosgdb.dll) mingw32(libosgfx.dll) mingw32(libosgga.dll) mingw32(libosgmanipulator.dll) mingw32(libosgparticle.dll) mingw32(libosgpresentation.dll) mingw32(libosgshadow.dll) mingw32(libosgsim.dll) mingw32(libosgterrain.dll) mingw32(libosgtext.dll) mingw32(libosgui.dll) mingw32(libosgutil.dll) mingw32(libosgviewer.dll) mingw32(libosgvolume.dll) mingw32(libosgwidget.dll) mingw32(libpng16-16.dll) mingw32(libpoppler-glib-8.dll) mingw32(librsvg-2-2.dll) mingw32(libssp-0.dll) mingw32(libstdc++-6.dll) mingw32(libtiff-5.dll) mingw32(msvcrt.dll) mingw32(opengl32.dll) mingw32(user32.dll) mingw32(winmm.dll) mingw32(ws2_32.dll) mingw32(zlib1.dll) mingw32-crt mingw32-filesystem mingw32-pkg-config mingw64-OpenSceneGraph (rpmlib, GLIBC filtered): mingw64(gdi32.dll) mingw64(kernel32.dll) mingw64(libcairo-2.dll) mingw64(libcurl-4.dll) mingw64(libfontconfig-1.dll) mingw64(libfreetype-6.dll) mingw64(libgcc_s_seh-1.dll) mingw64(libgdal-30.dll) mingw64(libgif-7.dll) mingw64(libgobject-2.0-0.dll) mingw64(libgta-1.dll) mingw64(libimath-3_1.dll) mingw64(libintl-8.dll) mingw64(libjasper-4.dll) mingw64(libjpeg-62.dll) mingw64(libopenexr-3_1.dll) mingw64(libopenthreads.dll) mingw64(libosg.dll) mingw64(libosganimation.dll) mingw64(libosgdb.dll) mingw64(libosgfx.dll) mingw64(libosgga.dll) mingw64(libosgmanipulator.dll) mingw64(libosgparticle.dll) mingw64(libosgpresentation.dll) mingw64(libosgshadow.dll) mingw64(libosgsim.dll) mingw64(libosgterrain.dll) mingw64(libosgtext.dll) mingw64(libosgui.dll) mingw64(libosgutil.dll) mingw64(libosgviewer.dll) mingw64(libosgvolume.dll) mingw64(libosgwidget.dll) mingw64(libpng16-16.dll) mingw64(libpoppler-glib-8.dll) mingw64(librsvg-2-2.dll) mingw64(libssp-0.dll) mingw64(libstdc++-6.dll) mingw64(libtiff-5.dll) mingw64(msvcrt.dll) mingw64(opengl32.dll) mingw64(user32.dll) mingw64(winmm.dll) mingw64(ws2_32.dll) mingw64(zlib1.dll) mingw64-crt mingw64-filesystem mingw64-pkg-config mingw32-OpenSceneGraph-tools (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(libgcc_s_dw2-1.dll) mingw32(libopenthreads.dll) mingw32(libosg.dll) mingw32(libosgdb.dll) mingw32(libosgga.dll) mingw32(libosgpresentation.dll) mingw32(libosgutil.dll) mingw32(libosgviewer.dll) mingw32(libosgvolume.dll) mingw32(libstdc++-6.dll) mingw32(msvcrt.dll) mingw32(ws2_32.dll) mingw32-crt mingw32-filesystem mingw64-OpenSceneGraph-tools (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(libgcc_s_seh-1.dll) mingw64(libopenthreads.dll) mingw64(libosg.dll) mingw64(libosgdb.dll) mingw64(libosgga.dll) mingw64(libosgpresentation.dll) mingw64(libosgutil.dll) mingw64(libosgviewer.dll) mingw64(libosgvolume.dll) mingw64(libstdc++-6.dll) mingw64(msvcrt.dll) mingw64(ws2_32.dll) mingw64-crt mingw64-filesystem mingw32-OpenSceneGraph-debuginfo (rpmlib, GLIBC filtered): mingw64-OpenSceneGraph-debuginfo (rpmlib, GLIBC filtered): Provides -------- mingw32-OpenSceneGraph: mingw32(libopenthreads.dll) mingw32(libosg.dll) mingw32(libosganimation.dll) mingw32(libosgdb.dll) mingw32(libosgfx.dll) mingw32(libosgga.dll) mingw32(libosgmanipulator.dll) mingw32(libosgparticle.dll) mingw32(libosgpresentation.dll) mingw32(libosgshadow.dll) mingw32(libosgsim.dll) mingw32(libosgterrain.dll) mingw32(libosgtext.dll) mingw32(libosgui.dll) mingw32(libosgutil.dll) mingw32(libosgviewer.dll) mingw32(libosgvolume.dll) mingw32(libosgwidget.dll) mingw32(mingw_osgdb_3dc.dll) mingw32(mingw_osgdb_3ds.dll) mingw32(mingw_osgdb_ac.dll) mingw32(mingw_osgdb_bmp.dll) mingw32(mingw_osgdb_bsp.dll) mingw32(mingw_osgdb_bvh.dll) mingw32(mingw_osgdb_cfg.dll) mingw32(mingw_osgdb_curl.dll) mingw32(mingw_osgdb_dds.dll) mingw32(mingw_osgdb_deprecated_osg.dll) mingw32(mingw_osgdb_deprecated_osganimation.dll) mingw32(mingw_osgdb_deprecated_osgfx.dll) mingw32(mingw_osgdb_deprecated_osgparticle.dll) mingw32(mingw_osgdb_deprecated_osgshadow.dll) mingw32(mingw_osgdb_deprecated_osgsim.dll) mingw32(mingw_osgdb_deprecated_osgterrain.dll) mingw32(mingw_osgdb_deprecated_osgtext.dll) mingw32(mingw_osgdb_deprecated_osgviewer.dll) mingw32(mingw_osgdb_deprecated_osgvolume.dll) mingw32(mingw_osgdb_deprecated_osgwidget.dll) mingw32(mingw_osgdb_dot.dll) mingw32(mingw_osgdb_dxf.dll) mingw32(mingw_osgdb_exr.dll) mingw32(mingw_osgdb_freetype.dll) mingw32(mingw_osgdb_gdal.dll) mingw32(mingw_osgdb_gif.dll) mingw32(mingw_osgdb_gles.dll) mingw32(mingw_osgdb_glsl.dll) mingw32(mingw_osgdb_gta.dll) mingw32(mingw_osgdb_gz.dll) mingw32(mingw_osgdb_hdr.dll) mingw32(mingw_osgdb_ive.dll) mingw32(mingw_osgdb_jp2.dll) mingw32(mingw_osgdb_jpeg.dll) mingw32(mingw_osgdb_ktx.dll) mingw32(mingw_osgdb_logo.dll) mingw32(mingw_osgdb_lua.dll) mingw32(mingw_osgdb_lwo.dll) mingw32(mingw_osgdb_lws.dll) mingw32(mingw_osgdb_md2.dll) mingw32(mingw_osgdb_mdl.dll) mingw32(mingw_osgdb_normals.dll) mingw32(mingw_osgdb_obj.dll) mingw32(mingw_osgdb_ogr.dll) mingw32(mingw_osgdb_openflight.dll) mingw32(mingw_osgdb_osc.dll) mingw32(mingw_osgdb_osg.dll) mingw32(mingw_osgdb_osga.dll) mingw32(mingw_osgdb_osgjs.dll) mingw32(mingw_osgdb_osgshadow.dll) mingw32(mingw_osgdb_osgterrain.dll) mingw32(mingw_osgdb_osgtgz.dll) mingw32(mingw_osgdb_osgviewer.dll) mingw32(mingw_osgdb_p3d.dll) mingw32(mingw_osgdb_pdf.dll) mingw32(mingw_osgdb_pic.dll) mingw32(mingw_osgdb_ply.dll) mingw32(mingw_osgdb_png.dll) mingw32(mingw_osgdb_pnm.dll) mingw32(mingw_osgdb_pov.dll) mingw32(mingw_osgdb_pvr.dll) mingw32(mingw_osgdb_revisions.dll) mingw32(mingw_osgdb_rgb.dll) mingw32(mingw_osgdb_rot.dll) mingw32(mingw_osgdb_scale.dll) mingw32(mingw_osgdb_serializers_osg.dll) mingw32(mingw_osgdb_serializers_osganimation.dll) mingw32(mingw_osgdb_serializers_osgfx.dll) mingw32(mingw_osgdb_serializers_osgga.dll) mingw32(mingw_osgdb_serializers_osgmanipulator.dll) mingw32(mingw_osgdb_serializers_osgparticle.dll) mingw32(mingw_osgdb_serializers_osgshadow.dll) mingw32(mingw_osgdb_serializers_osgsim.dll) mingw32(mingw_osgdb_serializers_osgterrain.dll) mingw32(mingw_osgdb_serializers_osgtext.dll) mingw32(mingw_osgdb_serializers_osgui.dll) mingw32(mingw_osgdb_serializers_osgutil.dll) mingw32(mingw_osgdb_serializers_osgviewer.dll) mingw32(mingw_osgdb_serializers_osgvolume.dll) mingw32(mingw_osgdb_shp.dll) mingw32(mingw_osgdb_stl.dll) mingw32(mingw_osgdb_svg.dll) mingw32(mingw_osgdb_tf.dll) mingw32(mingw_osgdb_tga.dll) mingw32(mingw_osgdb_tgz.dll) mingw32(mingw_osgdb_tiff.dll) mingw32(mingw_osgdb_trans.dll) mingw32(mingw_osgdb_trk.dll) mingw32(mingw_osgdb_txf.dll) mingw32(mingw_osgdb_txp.dll) mingw32(mingw_osgdb_vtf.dll) mingw32(mingw_osgdb_x.dll) mingw32(mingw_osgdb_zip.dll) mingw32-OpenSceneGraph mingw64-OpenSceneGraph: mingw64(libopenthreads.dll) mingw64(libosg.dll) mingw64(libosganimation.dll) mingw64(libosgdb.dll) mingw64(libosgfx.dll) mingw64(libosgga.dll) mingw64(libosgmanipulator.dll) mingw64(libosgparticle.dll) mingw64(libosgpresentation.dll) mingw64(libosgshadow.dll) mingw64(libosgsim.dll) mingw64(libosgterrain.dll) mingw64(libosgtext.dll) mingw64(libosgui.dll) mingw64(libosgutil.dll) mingw64(libosgviewer.dll) mingw64(libosgvolume.dll) mingw64(libosgwidget.dll) mingw64(mingw_osgdb_3dc.dll) mingw64(mingw_osgdb_3ds.dll) mingw64(mingw_osgdb_ac.dll) mingw64(mingw_osgdb_bmp.dll) mingw64(mingw_osgdb_bsp.dll) mingw64(mingw_osgdb_bvh.dll) mingw64(mingw_osgdb_cfg.dll) mingw64(mingw_osgdb_curl.dll) mingw64(mingw_osgdb_dds.dll) mingw64(mingw_osgdb_deprecated_osg.dll) mingw64(mingw_osgdb_deprecated_osganimation.dll) mingw64(mingw_osgdb_deprecated_osgfx.dll) mingw64(mingw_osgdb_deprecated_osgparticle.dll) mingw64(mingw_osgdb_deprecated_osgshadow.dll) mingw64(mingw_osgdb_deprecated_osgsim.dll) mingw64(mingw_osgdb_deprecated_osgterrain.dll) mingw64(mingw_osgdb_deprecated_osgtext.dll) mingw64(mingw_osgdb_deprecated_osgviewer.dll) mingw64(mingw_osgdb_deprecated_osgvolume.dll) mingw64(mingw_osgdb_deprecated_osgwidget.dll) mingw64(mingw_osgdb_dot.dll) mingw64(mingw_osgdb_dxf.dll) mingw64(mingw_osgdb_exr.dll) mingw64(mingw_osgdb_freetype.dll) mingw64(mingw_osgdb_gdal.dll) mingw64(mingw_osgdb_gif.dll) mingw64(mingw_osgdb_gles.dll) mingw64(mingw_osgdb_glsl.dll) mingw64(mingw_osgdb_gta.dll) mingw64(mingw_osgdb_gz.dll) mingw64(mingw_osgdb_hdr.dll) mingw64(mingw_osgdb_ive.dll) mingw64(mingw_osgdb_jp2.dll) mingw64(mingw_osgdb_jpeg.dll) mingw64(mingw_osgdb_ktx.dll) mingw64(mingw_osgdb_logo.dll) mingw64(mingw_osgdb_lua.dll) mingw64(mingw_osgdb_lwo.dll) mingw64(mingw_osgdb_lws.dll) mingw64(mingw_osgdb_md2.dll) mingw64(mingw_osgdb_mdl.dll) mingw64(mingw_osgdb_normals.dll) mingw64(mingw_osgdb_obj.dll) mingw64(mingw_osgdb_ogr.dll) mingw64(mingw_osgdb_openflight.dll) mingw64(mingw_osgdb_osc.dll) mingw64(mingw_osgdb_osg.dll) mingw64(mingw_osgdb_osga.dll) mingw64(mingw_osgdb_osgjs.dll) mingw64(mingw_osgdb_osgshadow.dll) mingw64(mingw_osgdb_osgterrain.dll) mingw64(mingw_osgdb_osgtgz.dll) mingw64(mingw_osgdb_osgviewer.dll) mingw64(mingw_osgdb_p3d.dll) mingw64(mingw_osgdb_pdf.dll) mingw64(mingw_osgdb_pic.dll) mingw64(mingw_osgdb_ply.dll) mingw64(mingw_osgdb_png.dll) mingw64(mingw_osgdb_pnm.dll) mingw64(mingw_osgdb_pov.dll) mingw64(mingw_osgdb_pvr.dll) mingw64(mingw_osgdb_revisions.dll) mingw64(mingw_osgdb_rgb.dll) mingw64(mingw_osgdb_rot.dll) mingw64(mingw_osgdb_scale.dll) mingw64(mingw_osgdb_serializers_osg.dll) mingw64(mingw_osgdb_serializers_osganimation.dll) mingw64(mingw_osgdb_serializers_osgfx.dll) mingw64(mingw_osgdb_serializers_osgga.dll) mingw64(mingw_osgdb_serializers_osgmanipulator.dll) mingw64(mingw_osgdb_serializers_osgparticle.dll) mingw64(mingw_osgdb_serializers_osgshadow.dll) mingw64(mingw_osgdb_serializers_osgsim.dll) mingw64(mingw_osgdb_serializers_osgterrain.dll) mingw64(mingw_osgdb_serializers_osgtext.dll) mingw64(mingw_osgdb_serializers_osgui.dll) mingw64(mingw_osgdb_serializers_osgutil.dll) mingw64(mingw_osgdb_serializers_osgviewer.dll) mingw64(mingw_osgdb_serializers_osgvolume.dll) mingw64(mingw_osgdb_shp.dll) mingw64(mingw_osgdb_stl.dll) mingw64(mingw_osgdb_svg.dll) mingw64(mingw_osgdb_tf.dll) mingw64(mingw_osgdb_tga.dll) mingw64(mingw_osgdb_tgz.dll) mingw64(mingw_osgdb_tiff.dll) mingw64(mingw_osgdb_trans.dll) mingw64(mingw_osgdb_trk.dll) mingw64(mingw_osgdb_txf.dll) mingw64(mingw_osgdb_txp.dll) mingw64(mingw_osgdb_vtf.dll) mingw64(mingw_osgdb_x.dll) mingw64(mingw_osgdb_zip.dll) mingw64-OpenSceneGraph mingw32-OpenSceneGraph-tools: mingw32-OpenSceneGraph-tools mingw64-OpenSceneGraph-tools: mingw64-OpenSceneGraph-tools mingw32-OpenSceneGraph-debuginfo: mingw32-OpenSceneGraph-debuginfo mingw64-OpenSceneGraph-debuginfo: mingw64-OpenSceneGraph-debuginfo -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2024130 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
