https://bugzilla.redhat.com/show_bug.cgi?id=2024924 --- Comment #5 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Hi Hafsat, Thanks for the review! I'll answer your queries below: (In reply to Hafsat from comment #4> > A couple of questions I have, > 1) What does it mean that "License file installed when any subpackage > combination is installed."I have checked and it's license is MIT, which is > open source but I am not sure about the installation being referred to here. As you know, a spec can include multiple-sub packages. Sometimes more than one of them are installed simultaneously. In such cases, we need to check that whatever combination of sub-packages are installed, the license file is installed. It doesn't apply here because there's only one sub-package, and so that should include the license file. > > 2) I am not sure how to determine if a package has a bundled library, so I > put a "?" there This requires us to check the source code. Usually, these are kept in folders called "lib" or "extra" but it varies from software to software. You'll get better at spotting these as you do more reviews. > > 3)How do I check that development files are in a -devel package? This usually applies to C/C++ software. Python modules just go into the python3- subpackage. > > 4) I can see the in %doc, there is READ.rst, HISTORY.rst and > CONTRIBUTING.rst and I don't think these are related to anything runtime but > there is "%{_bindir}/inspyred" and I do not know if and how this affects no > 51 of the review if it's not on the line starting with `%doc`, it isn't being marked as documentation. So, that's fine. > > 5) Why is the %{forgeurl} and %{forgesource} in the source0 and url? These are the forge macros: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_using_forges_hosted_revision_control > > 6) I don't understand no 63, how to check if large documentation goes in a > -doc subpackage? fedora-review will tell you the size of the documentation if it's not in the -doc subpackage. This is because adding large documentation to the main package will increase it's size, so we put it in the -doc sub-package so that users can install it if they wish. > > 7) How do I check if the source package includes the text of the License? Is > that the licensecheck.txt? Also didn't see %license in the spec file or is > the license field, above the URL? The %pyproject_save_files macro also pulls in the license file, so we don't need to mention it again in %license. The way to check this is to use `rpm -ql --licensefiles -p <path to your rpm file>` > > 8) How can you check if the package functions as described? You install it and run some examples listed in the documentation etc. A quick check will do---the person packaging generally checks this. > > 9) How can I verify the sources with gpgverify? This is documented here. We only do this if the developers sign the sources with gpg keys (which is not often) > > 10) How do I check if Python eggs downloaded any dependencies during the > build process? You check the build log to see if anything was downloaded. When building with mock, mock disables network for the build so this should not happen. > > 11) It has %check but the build.log contains no information about tests > carried out, so how do I know if the tests have been passed? DO I run a > fedpkg mockbuild? I ran the rpmlint on the srpm and it passed, I am not sure > if that matters? hrm, that's odd. It should have the information about the tests. As you see from the spec, you'll see that we run pytest. Here's the build log for rawhide, see how pytest is run in %check: https://kojipkgs.fedoraproject.org//packages/python-inspyred/1.0.1/4.20211119gitd5976ab.fc36/data/logs/noarch/build.log > > I tried to do an intensive review so I have a better idea of other > reviews....thank you for the platform. That's good. This is exactly why we ask you to do reviews :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2024924 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
