https://bugzilla.redhat.com/show_bug.cgi?id=2011830 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- > BuildRequires > FIX: Please add build-requires: > coreutils - spec file: line 78 > make - spec file: line 69,73,82 > perl-interpreter - spec file: line 55,68 > perl(Compress::Raw::Zlib) - t/111const-deflate.t:30 > perl(Cwd) - t/010main-unzip.t:18 > perl(Encode) - t/001main.t:30 > perl(File::Copy) - private/MakeUtil.pm:7 > perl(POSIX) - t/001main.t:109 > perl(Test::More) - t/meta-json.t:7 Done. > TODO: Please add BR perl(Test::NoWarnings) which is optional for tests Done. > TODO: Please consider using macro for version of IO::Compress* and > IO::Uncompress* modules. Done. > If you don't add the package to EPEL 7, please consider fixing > these 'TODO' items: > TODO: Add "NO_PACKLIST=1 NO_PERLLOCAL=1" to 'perl Makefile.PL' > If you use option NO_PACKLIST=1, please add version constrain > to ExtUtils::MakeMaker >= 6.76 > Remove 'find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} > \;'. > TODO: Use %{make_install} instead of "make pure_install". > TODO: Remove the deleting empty directories in %install section. All done. $ rpm -qp --requires perl-Archive-Zip-SimpleZip-0.040-2.fc36.noarch.rpm | grep -v rpmlib | sort | uniq -c 1 perl(bytes) 1 perl(Carp) 1 perl(Config) 1 perl(constant) 1 perl(Exporter) 1 perl(Fcntl) 1 perl(File::Basename) 1 perl(File::Path) 1 perl(File::Spec) 1 perl(IO::Compress::Adapter::Deflate) >= 2.096 1 perl(IO::Compress::Base) >= 2.096 1 perl(IO::Compress::Base::Common) >= 2.096 1 perl(IO::Compress::Bzip2) >= 2.096 1 perl(IO::Compress::Lzma) >= 2.096 1 perl(IO::Compress::RawDeflate) >= 2.096 1 perl(IO::Compress::Xz) >= 2.096 1 perl(IO::Compress::Zip) >= 2.096 1 perl(IO::Compress::Zip::Constants) >= 2.096 1 perl(IO::Compress::Zstd) >= 2.096 1 perl(IO::File) 1 perl(IO::Uncompress::Base) >= 2.096 1 perl(IO::Uncompress::Bunzip2) >= 2.096 1 perl(IO::Uncompress::RawInflate) >= 2.096 1 perl(IO::Uncompress::UnLzma) >= 2.096 1 perl(IO::Uncompress::UnXz) >= 2.096 1 perl(IO::Uncompress::Unzip) >= 2.096 1 perl(IO::Uncompress::UnZstd) >= 2.096 1 perl(:MODULE_COMPAT_5.34.0) 1 perl(Perl::OSType) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(:VERSION) >= 5.6.0 1 perl(warnings) Binary requires are ok. $ rpm -qp --provides perl-Archive-Zip-SimpleZip-0.040-2.fc36.noarch.rpm | sort | uniq -c 1 perl(Archive::Zip::SimpleUnzip) = 0.040 1 perl(Archive::Zip::SimpleUnzip::Handle) 1 perl(Archive::Zip::SimpleUnzip::Member) 1 perl(Archive::Zip::SimpleZip) = 0.040 1 perl-Archive-Zip-SimpleZip = 0.040-2.fc36 1 perl(Archive::Zip::SimpleZip::Handle) 1 perl(Archive::Zip::StreamedUnzip) = 0.040 1 perl(Archive::Zip::StreamedUnzip::Handle) 1 perl(Archive::Zip::StreamedUnzip::Member) Binary provides are ok. The package is in line with Fedora and Perl packaging guide lines. Resolution: Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2011830 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
