https://bugzilla.redhat.com/show_bug.cgi?id=2011830 --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok BuildRequires FIX: Please add build-requires: coreutils - spec file: line 78 make - spec file: line 69,73,82 perl-interpreter - spec file: line 55,68 perl(Compress::Raw::Zlib) - t/111const-deflate.t:30 perl(Cwd) - t/010main-unzip.t:18 perl(Encode) - t/001main.t:30 perl(File::Copy) - private/MakeUtil.pm:7 perl(POSIX) - t/001main.t:109 perl(Test::More) - t/meta-json.t:7 TODO: Please add BR perl(Test::NoWarnings) which is optional for tests TODO: Please consider using macro for version of IO::Compress* and IO::Uncompress* modules. If you don't add the package to EPEL 7, please consider fixing these 'TODO' items: TODO: Add "NO_PACKLIST=1 NO_PERLLOCAL=1" to 'perl Makefile.PL' If you use option NO_PACKLIST=1, please add version constrain to ExtUtils::MakeMaker >= 6.76 Remove 'find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;'. TODO: Use %{make_install} instead of "make pure_install". TODO: Remove the deleting empty directories in %install section. If you add it to EPEL 7, please do: TODO: Replace PERL_INSTALL_ROOT with more common DESTDIR. FIX: Add following build-requires 'findutils' used in spec file. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. FIX: Build failed due to missing BR 'make'. + /usr/bin/make -j8 V=1 VERBOSE=1 /var/tmp/rpm-tmp.MIdw0C: line 33: /usr/bin/make: No such file or directory I will check binary provides and requires after successful build. Resolution: Not Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2011830 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
