https://bugzilla.redhat.com/show_bug.cgi?id=2005132 Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(sanjay.ankur@gmai | |l.com) | --- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Hi Ben, thanks for the review. I've dropped the doc sub-package for the moment, and enabled the import test. Updated spec/srpm: https://ankursinha.fedorapeople.org/python-hdf5storage/python-hdf5storage.spec https://ankursinha.fedorapeople.org/python-hdf5storage/python-hdf5storage-0.1.18-2.fc36.src.rpm Cheers, Ankur diff --git a/python-hdf5storage.spec b/python-hdf5storage.spec index 25a4ab2..9fce3ed 100644 --- a/python-hdf5storage.spec +++ b/python-hdf5storage.spec @@ -47,16 +47,6 @@ BuildRequires: %{py3_dist nose} %description -n python3-hdf5storage %_description -%package doc -Summary: Documentation for %{name} -BuildRequires: make -BuildRequires: %{py3_dist sphinx} -BuildRequires: %{py3_dist numpydoc} -BuildRequires: %{py3_dist sphinx-rtd-theme} - -%description doc -This package provides documentation for %{name}. - %prep %forgesetup @@ -65,16 +55,12 @@ This package provides documentation for %{name}. # find . -type f -name "*.py" -exec sed -i '/^#![ ]*\/usr\/bin\/env.*$/ d' {} 2>/dev/null ';' %generate_buildrequires -%pyproject_buildrequires %{?with_tests:-r} +%pyproject_buildrequires -r %build %pyproject_wheel -# Sometimes needed so sphinx can import the module -PYTHONPATH=".:.." make -C doc SPHINXBUILD=sphinx-build-3 html -rm -rf doc/build/html/{.doctrees,.buildinfo} -vf - %install %pyproject_install %pyproject_save_files hdf5storage @@ -82,15 +68,11 @@ rm -rf doc/build/html/{.doctrees,.buildinfo} -vf %check %if %{with tests} %{pytest} -# or %%{tox} %endif +%pyproject_check_import hdf5storage %files -n python3-hdf5storage -f %{pyproject_files} %doc README.rst -%files doc -%license COPYING.txt -%doc doc/build/html - %changelog %autochangelog -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2005132 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure