https://bugzilla.redhat.com/show_bug.cgi?id=2011828 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- > FIX: Please switch source from www.cpan.org to metacpan.org Ok. > BuildRequires > FIX: Please add build-requires: > TODO: Add optional test build-require 'perl(Test::NoWarnings)' Ok. Ok. > If you don't add the package to EPEL 7, please consider fixing > these 'TODO' items: > TODO: Add "NO_PACKLIST=1 NO_PERLLOCAL=1" to 'perl Makefile.PL' > If you use option NO_PACKLIST=1, please add version constrain > to ExtUtils::MakeMaker >= 6.76 > Remove 'find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} > \;'. Ok. > TODO: Use %{make_install} instead of "make pure_install". Ok. > TODO: Remove the deleting empty directories in %install section. Ok The package is in line with Fedora and Perl packaging guide lines. Resolution: Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2011828 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
