https://bugzilla.redhat.com/show_bug.cgi?id=2023118 Maxwell G <gotmax@e.email> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |gotmax@e.email --- Comment #1 from Maxwell G <gotmax@e.email> --- Here are a couple informal suggestions: > %global pkg_name sphinx-markdown-tables You should replace `pkg_name` with `srcname`; that name is more descriptive and many other packages use that. > %description > A Sphinx extension for rendering tables written in markdown. > [...] > %description -n python3-%{pkg_name} > A Sphinx extension for rendering tables written in markdown. I recommend wrapping the description in a macro instead of repeating it twice. Here[1,2] are two examples. > %py3_check_import sphinx_markdown_tables If you want, you can replace this with %pyproject_check_import`[3]. It doesn't require any arguments; it imports all public modules found by the `%pyproject_save_files` macro. Maxwell [1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_empty_spec_file [2]: https://src.fedoraproject.org/rpms/yt-dlp/blob/rawhide/f/yt-dlp.spec#_24 [3]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_test_macros -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2023118 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
