[Bug 399341] Review Request: Nightfall - Nightfall is an astronomy application for emulation of eclipsing stars

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Nightfall - Nightfall is an astronomy application for emulation of eclipsing stars


https://bugzilla.redhat.com/show_bug.cgi?id=399341





------- Additional Comments From lkundrak@xxxxxxxxxx  2007-11-27 07:10 EST -------
Thanks. Please,

-make 'CPPFLAGS=-I/usr/include/gtk-2.0' 'CFLAGS=%{optflags}' %{_smp_mflags}
+make %{_smp_mflags}

As we talked about on IRC. Also,

sed -i 's/INSTALL} -s/INSTALL}/' Makefile

This kind of things is usually achieved via patches.

Also, could you please explain why did you introduce this?

%{_datadir}/*

Do you own all these?

nightfall.x86_64: E: standard-dir-owned-by-package /usr/share/man/man1
nightfall.x86_64: E: standard-dir-owned-by-package /usr/share/man

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]