[Bug 2018694] Review Request: clapper - 0.4.0 - GStreamer-based GNOME media player built using GJS and GTK4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2018694



--- Comment #6 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> ---
> Requires:      gstreamer1

Should be removed. Already exists in autodeps as
libgstreamer-1.0.so.0()(64bit).

> Requires:      gtk4

Should be removed. Already exists in autodeps as libgtk-4.so.1()(64bit).

> Requires:      libadwaita

If it needed, please add %{_isa}:
Requires:      libadwaita%{_isa}

%files
%files -f com.github.rafostar.Clapper.lang

Duplicate specifications. Remove the first one.

> %{_datadir}/icons/hicolor/scalable/apps/com.github.rafostar.Clapper.svg
> %{_datadir}/icons/hicolor/symbolic/apps/com.github.rafostar.Clapper-symbolic.svg

Can be simplified:
%{_datadir}/icons/hicolor/*/apps/*.svg

> %{_bindir}/com.github.rafostar.Clapper
> %{_bindir}/com.github.rafostar.Clapper.Daemon
> %{_bindir}/com.github.rafostar.Clapper.Remote

Can be simplified:
%{_bindir}/com.github.rafostar.Clapper*

> %{_libdir}/com.github.rafostar.Clapper/
> %{_libdir}/com.github.rafostar.Clapper/girepository-1.0/GstClapper-1.0.typelib
> %{_libdir}/com.github.rafostar.Clapper/libgstclapper-1.0.so
> %{_libdir}/com.github.rafostar.Clapper/libgstclapper-1.0.so.0
> %{_libdir}/com.github.rafostar.Clapper/libgstclapper-1.0.so.0.4.0

Should be simplified:
%{_libdir}/com.github.rafostar.Clapper/

> - Use %find_lang macro
> - Add missing %doc

You must escape all macroses in %changelog section, or they will expanded and
cause different unforeseen consequences.

Use double %% to escape them: %find_lang -> %%find_lang, %doc -> %%doc or just
remove them from changelog.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2018694
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux