[Bug 2022176] Review Request: system76-keyboard-configurator - System76 Keyboard Configurator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2022176



--- Comment #6 from Neal Gompa <ngompa13@xxxxxxxxx> ---
> BuildRequires: libudev-devel
> BuildRequires: hidapi-devel
> [...]
> BuildRequires: (crate(hidapi/linux-static-hidraw) >= 1.2.0 with crate(hidapi/linux-static-hidraw) < 2.0.0~)

This should be changed to use the "linux-shared-hidraw" feature instead in the
backend Cargo.toml:
https://github.com/pop-os/keyboard-configurator/blob/666266c60c89186b829efdfb061f7cde1271deb5/backend/Cargo.toml#L12

That will also let you drop hidapi-devel BR here (and probably libudev-devel BR
too) since the changes I requested in bug 2022179 will propagate up the needed
build dependencies.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2022176
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux