https://bugzilla.redhat.com/show_bug.cgi?id=2022179 --- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> --- There seems to be a couple things wrong with this crate package: * The build dependency "libusb-devel" is wrong, as the crate sources don't actually ask for libusb-0.1 at all (it wants libusb1 instead) * The default feature set in cargo can't be used since we don't ship the static library for hidraw or libusb1 This crate needs work to be packaged properly. The following things need to happen here: * The "static" feature subpackages need to be removed, as we don't have the static libraries for them * The crate's "default" feature set needs to be changed to "LINUX_SHARED_HIDRAW" in the Cargo.toml: https://github.com/ruabmbua/hidapi-rs/blob/master/Cargo.toml * The "static" features in Cargo.toml need to be removed, so that we don't generate dependencies for them * The BuildRequires needs to be switched to "pkgconfig(hidapi-hidraw)" * The +linux-shared-hidraw-devel subpackage needs "Requires: pkgconfig(hidapi-hidraw)" * The +linux-shared-libusb-devel subpackage needs "Requires: pkgconfig(hidapi-libusb)" -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2022179 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
