https://bugzilla.redhat.com/show_bug.cgi?id=2022991 Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vitaly@xxxxxxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> --- 1. You shouldn't use macroses with double underline (%{__install}). 2. systemd units and logic should be moved to the base package. 3. `%cmake3` should be used only on EPEL7. On Fedora and EPEL8+EPEL9 should be used %cmake. 4. `chrpath -d i2pd` can be dropped. Use `-DCMAKE_SKIP_INSTALL_RPATH:BOOL=ON` instead. 5. `%{_builddir}/%{name}-%{version}/contrib/i2pd.conf` - always use relative paths. 6. `Move config files from old version to proper place` - such scriplets are not allowed. You must install everything in %install. 7. Add %changelog section. 8. `Obsoletes: %{name}-daemon` - can be removed. Fedora has no package with such name. 9. `cd build` should be dropped. %cmake macro will do everything automatically. 10. `%{?cmake3_build}%{?!cmake3_build:%{make_build}}` must be replaced with `%cmake_build`. 11. `%{?__cmake_builddir:cd %{__cmake_builddir}}` can be dropped. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2022991 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
