https://bugzilla.redhat.com/show_bug.cgi?id=2022554 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(code@musicinmybra | |in.net) | --- Comment #5 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Dist tag is present. OK; fedora-review does not understand rpmautospec. - This is the first time I have seen rpmautospec combined with package unretirement. It makes sense to do. Just make sure that you end up with a release number higher than the last build (-34) to avoid unintended downgrades, using the -b option to %autorelease if needed. - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/plotmm See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names OK; this is a review for unretirement. - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1075200 bytes in 174 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation You should make a new -doc subpackage. I suggest something like: %package doc Summary: Documentation for plotmm BuildArch: noarch %description doc %{summary}. %files doc %license COPYING %doc doc/html (and remove the HTML documentation from the -devel package). You can keep AUTHORS, ChangeLog, and README in the base package or move them to -doc at your discretion. - Be warned that modern Doxygen-generated HTML documentation is not suitable for packaging, as it has relatively intractable issues with bundled and minified JavaScript. See https://bugzilla.redhat.com/show_bug.cgi?id=2006555 for details. However, the ancient pre-generated documentation here is OK: it lacks JavaScript, and the CSS is not minified. If you ever re-build the documentation in the RPM build, which is possible to do, then you will need to deal with this. The best solution is probably to build a PDF instead of HTML. See https://src.fedoraproject.org/rpms/cairomm/blob/rawhide/f/cairomm.spec for an example of doing this. (The example also builds the HTML with the JavaScript stripped out, but that is only so that DevHelp documentation—which plotmm does not provide—keeps working.) - The option “--enable-docs” to the configure script is not doing anything and should be removed. - Since the dependency on gtkmm is via pkgconfig, please change BuildRequires: gtkmm24-devel >= 2.4.0 to BuildRequires: pkgconfig(gtkmm-2.4) and Requires: gtkmm24-devel to Requires: pkgconfig(gtkmm-2.4) See https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/, and also https://docs.fedoraproject.org/en-US/packaging-guidelines/#_package_dependencies regarding versioned dependencies. - While the URL only works with plain HTTP, the Source0 URL still works with HTTPS. Please adjust it to HTTPS. - This project is thoroughly dead upstream. It’s okay to keep packaging it, but you will have a higher burden as maintainer should any issues arise. - You should not glob the shared library in a way that would miss an soversion bump. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files. Plus, it’s best not to use extremely broad globs under shared directories. There are some arguments for not doing so in https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_explicit_lists. At least change: %{_libdir}/*.so.* to: %{_libdir}/*.so.0* but preferably: %{_libdir}/libplotmm.so.0* or: %{_libdir}/libplotmm.so.0 %{_libdir}/libplotmm.so.0.* - This is obsolete in all current Fedora releases and should be removed: %ldconfig_scriptlets - While the make invocations are acceptable, it would be even better to write make %{?_smp_mflags} as %make_build and make DESTDIR=%{buildroot} install as %make_install - This is a nit-pick, but find %{buildroot} -type f -name "*.la" -exec rm -f {} ';' could be more simply written as find '%{buildroot}' -type f -name '*.la' -delete - The spec file contains mixed spaces and tabs. You can fix it with: sed -r -i 's/\t/ /g' plotmm.spec See rpmlint diagnostics: plotmm.spec:44: W: mixed-use-of-spaces-and-tabs (spaces: line 10, tab: line 44) plotmm.spec:44: W: mixed-use-of-spaces-and-tabs (spaces: line 10, tab: line 44) - I think all of these rpmlint messages are spurious and require no action: plotmm.src: W: strange-permission plotmm.spec 600 plotmm.x86_64: E: shlib-policy-name-error 0 plotmm-examples.x86_64: W: no-documentation plotmm-devel.x86_64: W: missing-dependency-on plotmm*/plotmm-libs/libplotmm* = 0.1.2 plotmm.x86_64: E: invalid-ldconfig-symlink /usr/lib64/libplotmm.so.0.0.0 libplotmm.so.0.0.0 plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_error_curve__inherit__graph.dot /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_error_curve__coll__graph.dot plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_error_curve__inherit__graph.map /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_error_curve__coll__graph.map plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_error_curve__inherit__graph.md5 /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_error_curve__coll__graph.md5 plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_error_curve__inherit__graph.png /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_error_curve__coll__graph.png plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_v_scale__coll__graph.map /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_h_scale__coll__graph.map plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_v_scale__inherit__graph.map /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_h_scale__inherit__graph.map plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_h_scale_labels__inherit__graph.dot /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_h_scale_labels__coll__graph.dot plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_v_scale_labels__inherit__graph.map /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_h_scale_labels__coll__graph.map:/usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_h_scale_labels__inherit__graph.map:/usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_v_scale_labels__coll__graph.map plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_h_scale_labels__inherit__graph.md5 /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_h_scale_labels__coll__graph.md5 plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_h_scale_labels__inherit__graph.png /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_h_scale_labels__coll__graph.png plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_v_scale_labels__inherit__graph.dot /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_v_scale_labels__coll__graph.dot plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_v_scale_labels__inherit__graph.md5 /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_v_scale_labels__coll__graph.md5 plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_v_scale_labels__inherit__graph.png /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_v_scale_labels__coll__graph.png - Simple man pages explaining what the examples do would be nice, but are not required. See rpmlint diagnostics: plotmm-examples.x86_64: W: no-manual-page-for-binary plotmm-curves plotmm-examples.x86_64: W: no-manual-page-for-binary plotmm-simple and also https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages. - This should be reported upstream, although given plotmm seems to be abandoned, I wouldn’t expect doing so to accomplish anything. plotmm.x86_64: E: incorrect-fsf-address /usr/share/licenses/plotmm/COPYING You are required to report this, but you must not patch the file yourself; see https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Library General Public License, Version 2.0", "FSF Unlimited License (with License Retention)", "GNU General Public License v2.0 or later [generated file]", "FSF Unlimited License [generated file]", "GNU General Public License v2.0 or later", "X11 License [generated file]", "GNU Lesser General Public License". 189 files have unknown license. Detailed output of licensecheck in /home/reviewer/2022554-plotmm/licensecheck.txt All files with licenses other than LGPLv2 belong to the build system and do not contribute to the License of the binary RPMs. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines (except as mentioned) [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in plotmm- devel , plotmm-examples [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. Upstream provides no tests. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) OK: fedora-review does not understand rpmautospec [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1198080 bytes in /usr/share Documentation should be moved to a noarch -doc subpackage. [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- http://download.sourceforge.net/plotmm/plotmm-0.1.2.tar.gz : CHECKSUM(SHA256) this package : 896bb729eb9cad5f3188d72304789dd7a86fdae66020ac0632fe3bc66abe9653 CHECKSUM(SHA256) upstream package : 896bb729eb9cad5f3188d72304789dd7a86fdae66020ac0632fe3bc66abe9653 Requires -------- plotmm (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) plotmm-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config gtkmm24-devel libplotmm.so.0()(64bit) pkgconfig(gtkmm-2.4) plotmm(x86-64) plotmm-examples (rpmlib, GLIBC filtered): libatkmm-1.6.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgdkmm-2.4.so.1()(64bit) libglibmm-2.4.so.1()(64bit) libgtkmm-2.4.so.1()(64bit) libm.so.6()(64bit) libplotmm.so.0()(64bit) libsigc-2.0.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) plotmm(x86-64) rtld(GNU_HASH) plotmm-debuginfo (rpmlib, GLIBC filtered): plotmm-debugsource (rpmlib, GLIBC filtered): Provides -------- plotmm: libplotmm.so.0()(64bit) plotmm plotmm(x86-64) plotmm-devel: pkgconfig(plotmm) plotmm-devel plotmm-devel(x86-64) plotmm-examples: plotmm-examples plotmm-examples(x86-64) plotmm-debuginfo: debuginfo(build-id) libplotmm.so.0.0.0-0.1.2-2.fc36.x86_64.debug()(64bit) plotmm-debuginfo plotmm-debuginfo(x86-64) plotmm-debugsource: plotmm-debugsource plotmm-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/reviewer/2022554-plotmm/srpm/plotmm.spec 2021-11-13 08:49:05.052705243 -0500 +++ /home/reviewer/2022554-plotmm/srpm-unpacked/plotmm.spec 2021-11-11 19:10:50.000000000 -0500 @@ -1,2 +1,11 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.2.5) +%define autorelease(e:s:pb:) %{?-p:0.}%{lua: + release_number = 2; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{?dist} +## END: Set by rpmautospec + Name: plotmm Version: 0.1.2 @@ -80,3 +89,7 @@ %changelog -%autochangelog +* Fri Nov 12 2021 Nils Philippsen <nils@xxxxxxxxxx> 0.1.2-2 +- Uncommitted changes + +* Thu Nov 11 2021 Nils Philippsen <nils@xxxxxxxxxx> 0.1.2-1 +- Revert "Orphaned for 6+ weeks" Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2022554 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: PHP, Ocaml, Perl, Haskell, SugarActivity, R, Python, fonts, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH ============================ rpmlint session starts ============================ rpmlint: 2.1.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 5 plotmm.src: W: strange-permission plotmm.spec 600 plotmm.x86_64: E: shlib-policy-name-error 0 plotmm-examples.x86_64: W: no-manual-page-for-binary plotmm-curves plotmm-examples.x86_64: W: no-manual-page-for-binary plotmm-simple plotmm-examples.x86_64: W: no-documentation plotmm.spec:44: W: mixed-use-of-spaces-and-tabs (spaces: line 10, tab: line 44) plotmm.spec:44: W: mixed-use-of-spaces-and-tabs (spaces: line 10, tab: line 44) plotmm-devel.x86_64: W: missing-dependency-on plotmm*/plotmm-libs/libplotmm* = 0.1.2 plotmm.x86_64: E: invalid-ldconfig-symlink /usr/lib64/libplotmm.so.0.0.0 libplotmm.so.0.0.0 plotmm.x86_64: E: incorrect-fsf-address /usr/share/licenses/plotmm/COPYING plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_error_curve__inherit__graph.dot /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_error_curve__coll__graph.dot plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_error_curve__inherit__graph.map /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_error_curve__coll__graph.map plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_error_curve__inherit__graph.md5 /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_error_curve__coll__graph.md5 plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_error_curve__inherit__graph.png /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_error_curve__coll__graph.png plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_v_scale__coll__graph.map /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_h_scale__coll__graph.map plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_v_scale__inherit__graph.map /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_h_scale__inherit__graph.map plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_h_scale_labels__inherit__graph.dot /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_h_scale_labels__coll__graph.dot plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_v_scale_labels__inherit__graph.map /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_h_scale_labels__coll__graph.map:/usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_h_scale_labels__inherit__graph.map:/usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_v_scale_labels__coll__graph.map plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_h_scale_labels__inherit__graph.md5 /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_h_scale_labels__coll__graph.md5 plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_h_scale_labels__inherit__graph.png /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_h_scale_labels__coll__graph.png plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_v_scale_labels__inherit__graph.dot /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_v_scale_labels__coll__graph.dot plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_v_scale_labels__inherit__graph.md5 /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_v_scale_labels__coll__graph.md5 plotmm-devel.x86_64: W: files-duplicate /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_v_scale_labels__inherit__graph.png /usr/share/doc/plotmm-devel/html/class_plot_m_m_1_1_v_scale_labels__coll__graph.png 4 packages and 1 specfiles checked; 3 errors, 20 warnings, 3 badness; has taken 0.8 s -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2022554 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
