https://bugzilla.redhat.com/show_bug.cgi?id=1979790 Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #14 from Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> --- Hi Davide, Thank you for your quick reply! Package is almost approved. Please add a copy of the LICENSE file to -doc subpackage if -doc subpackage is independent of -devel package. ``` %files doc %doc docs %license LICENSE <--- this line is needed. ``` If -doc package is dependent upon -devel package, please add "Requires:" tag to -doc subpackage. Please see: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#subpackage-licensing Regards, Hirotaka Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - The subpackage is independent of the base package but it doesn't have copies of any license texts. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [!]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- ``` $ rpmlint golang-github-schollz-cli-2-2.2.1-1.fc36.src.rpm ===================================================== rpmlint session starts ===================================================== rpmlint: 2.1.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 golang-github-schollz-cli-2.spec: W: no-%build-section golang-github-schollz-cli-2.spec:62: W: macro-in-%changelog %autochangelog ====================== 1 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.3 s ====================== $ rpmlint golang-github-schollz-cli-2-devel-2.2.1-1.fc36.noarch.rpm ===================================================== rpmlint session starts ===================================================== rpmlint: 2.1.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 golang-github-schollz-cli-2-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/schollz/cli/v2/.goipath golang-github-schollz-cli-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/schollz/cli/v2/CODE_OF_CONDUCT.md /usr/share/doc/golang-github-schollz-cli-2-devel/CODE_OF_CONDUCT.md golang-github-schollz-cli-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/schollz/cli/v2/README.md /usr/share/doc/golang-github-schollz-cli-2-devel/README.md ====================== 1 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.1 s ====================== $ rpmlint golang-github-schollz-cli-2-doc-2.2.1-1.fc36.noarch.rpm ===================================================== rpmlint session starts ===================================================== rpmlint: 2.1.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 ====================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s ====================== ``` Source checksums ---------------- https://github.com/schollz/cli/archive/v2.2.1/cli-2.2.1.tar.gz : CHECKSUM(SHA256) this package : c67fe8a60f9f53c99311aeac72c3b0b0c0fb0e1377286bed1e3c463b26c7bf3c CHECKSUM(SHA256) upstream package : c67fe8a60f9f53c99311aeac72c3b0b0c0fb0e1377286bed1e3c463b26c7bf3c Requires -------- golang-github-schollz-cli-2-doc (rpmlib, GLIBC filtered): golang-github-schollz-cli-2-devel (rpmlib, GLIBC filtered): go-filesystem golang(github.com/BurntSushi/toml) golang(github.com/cpuguy83/go-md2man/v2/md2man) golang(gopkg.in/yaml.v2) Provides -------- golang-github-schollz-cli-2-doc: golang-github-schollz-cli-2-doc golang-github-schollz-cli-2-devel: golang(github.com/schollz/cli/v2) golang(github.com/schollz/cli/v2/altsrc) golang-github-schollz-cli-2-devel golang-ipath(github.com/schollz/cli/v2) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1979790 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Perl, R, Ocaml, fonts, PHP, C/C++, Haskell, Java, Python, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1979790 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
