https://bugzilla.redhat.com/show_bug.cgi?id=2011828 --- Comment #3 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL is ok FIX: Please switch source from www.cpan.org to metacpan.org https://cpan.metacpan.org/modules/by-module/IO/IO-Compress-Zstd-%{version}.tar.gz All tests passed BuildRequires FIX: Please add build-requires: coreutils - perl-IO-Compress-Zstd.spec (line 45) perl-interpreter - perl-IO-Compress-Zstd.spec (line 22,35) perl(Carp) - t/compress/CompTestUtils.pm:11 perl(Compress::Raw::Zlib) - t/compress/merge.pl:9 [v2] perl(Compress::Stream::Zstd::Compressor) - lib/IO/Compress/Adapter/Zstd.pm:9 perl(Compress::Stream::Zstd::Decompressor) - lib/IO/Uncompress/Adapter/UnZstd.pm:9 perl(Config) - t/compress/oneshot.pl:116 perl(Exporter) - lib/IO/Compress/Zstd.pm:5 perl(File::Copy) - private/MakeUtil.pm:7 perl(File::Path) - t/compress/CompTestUtils.pm:69 perl(File::Spec) - t/050interop-zstd.t:13 perl(IO::Compress::Base::Common) - lib/IO/Compress/Zstd.pm:10 perl(IO::Compress::Zip) - t/105oneshot-zip-zstd.t:34 perl(IO::Compress::Zip::Constants) - t/105oneshot-zip-zstd.t:36 perl(IO::File) - t/compress/destroy.pl:22 perl(IO::Handle) - t/compress/generic.pl:8 perl(IO::Uncompress::AnyUncompress) - t/108anyunc-zstd.t:12 perl(IO::Uncompress::Unzip) - t/105oneshot-zip-zstd.t:35 perl(lib) - Makefile.PL:116 TODO: Add optional test build-require 'perl(Test::NoWarnings)' $ rpm -qp --requires perl-IO-Compress-Zstd-2.101-1.fc36.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(bytes) 1 perl(Compress::Stream::Zstd) 1 perl(Compress::Stream::Zstd::Compressor) 1 perl(Compress::Stream::Zstd::Decompressor) 1 perl(constant) 1 perl(Exporter) 1 perl(IO::Compress::Adapter::Zstd) >= 2.101 1 perl(IO::Compress::Base) >= 2.101 1 perl(IO::Compress::Base::Common) >= 2.101 1 perl(IO::Uncompress::Adapter::UnZstd) >= 2.101 1 perl(IO::Uncompress::Base) >= 2.101 1 perl(:MODULE_COMPAT_5.34.0) 1 perl(strict) 1 perl(warnings) Binary requires are Ok. $ rpm -qp --provides perl-IO-Compress-Zstd-2.101-1.fc36.noarch.rpm | sort | uniq -c 1 perl(IO::Compress::Adapter::Zstd) = 2.101 1 perl(IO::Compress::Zstd) = 2.101 1 perl-IO-Compress-Zstd = 2.101-1.fc36 1 perl(IO::Uncompress::Adapter::UnZstd) = 2.101 1 perl(IO::Uncompress::UnZstd) = 2.101 Binary provides are Ok. $ rpmlint ./perl-IO-Compress-Zstd* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok If you don't add the package to EPEL 7, please consider fixing these 'TODO' items: TODO: Add "NO_PACKLIST=1 NO_PERLLOCAL=1" to 'perl Makefile.PL' If you use option NO_PACKLIST=1, please add version constrain to ExtUtils::MakeMaker >= 6.76 Remove 'find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;'. TODO: Use %{make_install} instead of "make pure_install". TODO: Remove the deleting empty directories in %install section. If you add it to EPEL 7, please do: TODO: Replace PERL_INSTALL_ROOT with more common DESTDIR. FIX: Add following build-requires 'findutils' used in spec file. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: Not Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2011828 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
