https://bugzilla.redhat.com/show_bug.cgi?id=2013796 Carl George 🤠 <carl@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |carl@xxxxxxxxxx Flags| |fedora-review? CC| |carl@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #7 from Carl George 🤠 <carl@xxxxxxxxxx> --- Taking this review, and I can sponsor as well. It looks pretty good, just a few small corrections. [!]: Latest version is packaged. https://github.com/warpnet/salt-lint/releases/tag/v0.8.0 was tagged today, go ahead and update to that version. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. Add a comment above patch0 that clarifies it's a downstream-only patch, perhaps with a link to the linter section of the Python guidelines that was mentioned in comment 3. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2013796 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
