https://bugzilla.redhat.com/show_bug.cgi?id=2012522 --- Comment #23 from Maxwell G <gotmax@e.email> --- Hi Vitaly, (In reply to Vitaly Zaitsev from comment #19) > I will review this package and sponsor you Thanks for sponsoring me! (In reply to Vitaly Zaitsev from comment #20) > > # SPDX-FileCopyrightText: 2021 Maxwell G (@gotmax23) > > # SPDX-License-Identifier: Unlicense OR MIT > > Not allowed in Fedora and must be removed. > > All Fedora SPECs uses FPCA: > https://fedoraproject.org/wiki/Licensing:Main#License_of_Fedora_SPEC_Files > All original Fedora contributions are governed by the Fedora Project Contributor Agreement (FPCA). This means that unless a spec file contains an explicit license attribution within it, it is available under the terms of the MIT license. https://fedoraproject.org/wiki/Licensing:Main#License_of_Fedora_SPEC_Files: > Since every Fedora SPEC file is contributed by FPCA signers, every Fedora SPEC is available under these license terms (unless otherwise explicitly licensed). I explicitly dual licensed the spec under the Unlicense or MIT. > > #Recommends: ffmpeg ffprobe > > #Suggests: rtmpdump > > #Suggests: (mplayer or mpv) > > Must be removed. Fedora SPECs can't require packages from another > repositories. > > > # The commented out lines are available in RPMFusion. > > This must be done on RPM Fusion's side with adding Recommends: yt-dlp for > smplayer and other packages. Okay, I will remove this. > > %package bash-completion > > I think that extraction of *completion files to a separate packages is not a > good idea. They will never be installed, because you don't have Requires on > them. > > If you want subpackages, feel free to use them, but don't forget to require > them using Rich dependencies from the base package: > > Requires: (%{name}-bash-completion if bash) > Requires: (%{name}-zsh-completion if zsh) > Requires: (%{name}-fish-completion if fish) The `Supplements:` keys in the spec accomplish the same goal, while still allowing users to opt out by disabling weak deps. I explained this in this comment[1]. > > > %{_docdir}/yt_dlp/* > > Should be replaced with (without asterisk): > > %docdir %{_docdir}/%{name}/ > %{_docdir}/%{name}/ Done. (In reply to Vitaly Zaitsev from comment #21) > All files and directories provided by RPM package must be owned. That's why > you need to choose between these two strategies. [...] > > Strategy 2: explicitly require the corresponding packages. > > > %package bash-completion > > %package bash-completion > Requires: bash-completion > > > %package zsh-completion > > %package zsh-completion > Requires: zsh > > > %package fish-completion > > %package fish-completion > Requires: fish I was going to do this anyways[2], so that's what I will do. Maxwell [1]: https://bugzilla.redhat.com/show_bug.cgi?id=2012522#c15 [2]: https://bugzilla.redhat.com/show_bug.cgi?id=2012522#c18 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2012522 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
