https://bugzilla.redhat.com/show_bug.cgi?id=2021029 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > %configure > %{__make} %{?_smp_mflags} 1. Using macro forms of system executables (%{__make}, %{__rm}, etc.) is discouraged. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros 2. "%make_build" is preferred for building. > %files > %{_datarootdir}/%{name}/default.xml This will make the package own the "/usr/share/phonesim/default.xml" file, but not the "/usr/share/phonesim" directory. https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/ Also, the license file is not included in the package. Add "%license COPYING" under %files. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2021029 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
