https://bugzilla.redhat.com/show_bug.cgi?id=2012522 --- Comment #20 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> --- > # SPDX-FileCopyrightText: 2021 Maxwell G (@gotmax23) > # SPDX-License-Identifier: Unlicense OR MIT Not allowed in Fedora and must be removed. All Fedora SPECs uses FPCA: https://fedoraproject.org/wiki/Licensing:Main#License_of_Fedora_SPEC_Files > #Recommends: ffmpeg ffprobe > #Suggests: rtmpdump > #Suggests: (mplayer or mpv) Must be removed. Fedora SPECs can't require packages from another repositories. > # The commented out lines are available in RPMFusion. This must be done on RPM Fusion's side with adding Recommends: yt-dlp for smplayer and other packages. > %package bash-completion I think that extraction of *completion files to a separate packages is not a good idea. They will never be installed, because you don't have Requires on them. If you want subpackages, feel free to use them, but don't forget to require them using Rich dependencies from the base package: Requires: (%{name}-bash-completion if bash) Requires: (%{name}-zsh-completion if zsh) Requires: (%{name}-fish-completion if fish) > %{_docdir}/yt_dlp/* Should be replaced with (without asterisk): %docdir %{_docdir}/%{name}/ %{_docdir}/%{name}/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2012522 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
