[Bug 2017610] Review Request: python-git-changelog - Automatic Changelog generator using Jinja2 templates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2017610

Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
                   |needinfo?(code@musicinmybra |
                   |in.net)                     |



--- Comment #13 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
Thanks! Approved by inspection of the spec file diff:

---
20211108/2017610-python-git-changelog/srpm-unpacked/python-git-changelog.spec  
    2021-11-08 03:53:01.000000000 -0500
+++
20211108-2/2017610-python-git-changelog/srpm-unpacked/python-git-changelog.spec
    2021-11-08 10:33:42.000000000 -0500
@@ -1,13 +1,12 @@
 ## START: Set by rpmautospec
 ## (rpmautospec version 0.2.5)
 %define autorelease(e:s:pb:) %{?-p:0.}%{lua:
-    release_number = 7;
+    release_number = 8;
     base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
     print(release_number + base_release_number - 1);
 }%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{?dist}
 ## END: Set by rpmautospec

-%global         gittag 0.4.2
 Name:           python-git-changelog
 Version:        0.4.2
 Release:        %autorelease
@@ -15,7 +14,7 @@

 License:        ISC
 URL:            https://github.com/pawamoy/git-changelog
-Source0:       
https://github.com/pawamoy/git-changelog/archive/%{gittag}/%{name}-%{version}.tar.gz
+Source0:        %{url}/archive/%{version}/%{name}-%{version}.tar.gz
 Source1:        git-changelog.1

 BuildArch:      noarch
@@ -30,13 +29,14 @@
 %description %_description

 %package -n python3-git-changelog
+Requires:       git-core
 Summary:        %{summary}

 %description -n python3-git-changelog %_description


 %prep
-%autosetup -n git-changelog-%{gittag}
+%autosetup -n git-changelog-%{version}
 sed -i 's/^Jinja2.*/Jinja2 = "*"/' pyproject.toml


@@ -52,6 +52,8 @@
 install -m 0644 -p -D -t %{buildroot}%{_mandir}/man1 %{SOURCE1}
 %pyproject_install
 %pyproject_save_files git_changelog
+rm -fv %{buildroot}%{python3_sitelib}/README.md
+rm -fv %{buildroot}%{python3_sitelib}/pyproject.toml


 %check
@@ -63,13 +65,15 @@
 %license LICENSE*
 %{_bindir}/git-changelog
 %{_mandir}/man1/git-changelog.1*
-%exclude %{python3_sitelib}/README.md
-%exclude %{python3_sitelib}/pyproject.toml
+

 %changelog
-* Mon Nov 08 2021 Vanessa Christopher <vanessaigwe1@xxxxxxxxx> 0.4.2-7
+* Mon Nov 08 2021 Vanessa Christopher <vanessaigwe1@xxxxxxxxx> 0.4.2-8
 - Uncommitted changes

+* Mon Nov 08 2021 Vanessa Christopher <vanessaigwe1@xxxxxxxxx> 0.4.2-7
+- update the source to fetch from tag for version 0.4.2
+
 * Tue Nov 02 2021 Vanessa Christopher <vanessaigwe1@xxxxxxxxx> 0.4.2-6
 - Added man-page to package


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2017610
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux