[Bug 2010718] Review Request: alizams - A DICOM viewer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2010718



--- Comment #8 from Alessio <alciregi@xxxxxxxxxx> ---
(In reply to Artur Frenszek-Iwicki from comment #7)
> The sources used to build the linked SRPM do not match the upstream tarball
> that's specified as Source0.

Correct. Upstream made some minor changes to the code, releasing a new tag but
leaving the version to 1.7.1

> 
> Some quick notes in the meantime:
> 
> In the spec:
> > %files
> > %{_datadir}/%{name}/*
> This will make the package own files inside /usr/share/alizams, but not the
> directory itself.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/
> #_wildcarding_files_inside_a_created_directory

Yep.

> rpmlint messages:
> > alizams.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 13)
> There's a tab between the "URL:" tag and its value.

Whoops.

> 
> > E: specfile-error warning: bogus date in %changelog: Sun Oct 20 2021 
> Oct 20 was a Wednesday.

Whoops.

> 
> In alizams.appdata.xml:
> >   <screenshot type="default">
> >     <image>https://lh6.googleusercontent.com/gIyaJlPe0i6ZnjKCt4SlshvHG1b9KItl_4DEShBjXx2d5dHXO7f_vQw-UeobzMysC-2iBAqKf03H1ooobNbTfouXoLAHE2GU6mr3hz55W62NqTGt5mmYnSSG2Cltfr9zVA=w1280</image>
> >   </screenshot>
> This link gives me a 403.

Yes. Upstream had now provided "stable" pictures links:
https://github.com/AlizaMedicalImaging/AlizaMS/issues/2#issuecomment-950189749


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2010718
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux