https://bugzilla.redhat.com/show_bug.cgi?id=2018825 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(code@musicinmybra |needinfo?(iztok@iztok-jr-fi |in.net) |ster.eu) --- Comment #8 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Almost there! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ==== - Since there are no upstream tests, you must run an import smoke test (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_running_tests). Just add (preferably after %install, in place of the leftover comment # Do not install “examples” as a top-level package # https://github.com/VictorPelaez/coral-reef-optimization-algorithm/pull/59 # Patch1: %{url}/pull/59.patch ): %check # Upstream provides no tests %pyproject_check_import If you use %pyproject_check_import instead of %py3_check_import—and I recommend that you do—you will need to wait a few days for pyproject-rpm-macros-0-49 to reach stable before building for F35 or older. Even better would be: %check # Upstream provides no tests %pyproject_check_import # Also use the examples as “smoke tests” pushd examples for example in example_*.py do PYTHONPATH='%{buildroot}%{python3_sitelib}' %{python3} "${example}" done popd And we know that’s a good test because it fails! You’ll need another patch to fix it: # Import Bunch from sklearn.utils # https://github.com/VictorPelaez/coral-reef-optimization-algorithm/pull/63 # # Fixes: # Import of Bunch needs to be fixed for recent scikit-learn versions # https://github.com/VictorPelaez/coral-reef-optimization-algorithm/issues/62 Patch2: %{url}/pull/63.patch ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* MIT License", "MIT License". 16 files have unknown license. Detailed output of licensecheck in /home/reviewer/2018825-python- cro/20211105/2018825-python-cro/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python Since there are no upstream tests, you must run an import smoke test (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_running_tests). [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. Upstream provides no tests, so smoke tests are needed. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-cro-0.0.5.0-1.fc36.noarch.rpm python-cro-0.0.5.0-1.fc36.src.rpm python3-cro.noarch: W: spelling-error Summary(en_US) metaheuristic -> meta heuristic, meta-heuristic, heuristics python-cro.src: W: spelling-error Summary(en_US) metaheuristic -> meta heuristic, meta-heuristic, heuristics python-cro.src:71: W: macro-in-comment %{url} 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/VictorPelaez/coral-reef-optimization-algorithm/raw/cb11d529acd929c488bb433f8bb87f5d1988d923/LICENSE.txt : CHECKSUM(SHA256) this package : de73f284e92b36876e58ca486f87de9198cbdbed3035e378d38c45c672401b15 CHECKSUM(SHA256) upstream package : de73f284e92b36876e58ca486f87de9198cbdbed3035e378d38c45c672401b15 https://files.pythonhosted.org/packages/source/c/cro/cro-0.0.5.0.tar.gz : CHECKSUM(SHA256) this package : 88f058946ff2594439afc68f01553c6beb2777fe511bca65a70bb1447470295d CHECKSUM(SHA256) upstream package : 88f058946ff2594439afc68f01553c6beb2777fe511bca65a70bb1447470295d Requires -------- python3-cro (rpmlib, GLIBC filtered): python(abi) python3.10dist(matplotlib) python3.10dist(numpy) python3.10dist(pandas) python3.10dist(scikit-learn) python3.10dist(scipy) Provides -------- python3-cro: python-cro python3-cro python3.10-cro python3.10dist(cro) python3dist(cro) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2018825 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, Generic Disabled plugins: SugarActivity, R, Haskell, Java, PHP, C/C++, Ocaml, Perl, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2018825 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
