https://bugzilla.redhat.com/show_bug.cgi?id=2017610 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(vanessaigwe1@gmai | |l.com) --- Comment #6 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Sorry for keeping you waiting on this review. Before I finish the full review, I have a question: why did you choose to package from commit 8aaf3e8 rather than from the tag for version 0.4.2? Is there a particular fix you need from the commits after the 0.4.2 tag? It’s ok to do this (preferably given a concrete reason, which it’s nice to mention in a spec file comment), but you’ll need to ensure the snapshot information field is in the Release (https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots). The easiest way to add the snapshot information is to use the “forge” macros (https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_commit_example). ---- Other things at a glance: - I think CODE_OF_CONDUCT.md, CONTRIBUTING.md, and CREDITS.md should be installed with %doc, too. - While patching pyproject.toml to allow Jinja2 version 3.x is correct, you should ideally file an upstream issue asking them to add official support. ---- I’ll spend a little more time on it before posting the final review, but I don’t think I’ll find anything else—I can tell you’ve packaged carefully. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2017610 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
