https://bugzilla.redhat.com/show_bug.cgi?id=2016779 --- Comment #6 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Thanks for your reviews, they're very helpful! I'm looking at this now. A few starting points: - Please remove the quotes (") around the Summary - Some of your lines have extra spaces at the end (we call them trailing spaces). Can you remove these please? - i think it's best to use the rpmautospec macros now. So: * please replace "Release: 1%{?dist}" with "Release: %autorelease" * please remove all the changelog entries and use "%autochangelog". So it'll become: %changelog %autochangelog Please make these changes and upload the new spec and srpm and I'll do the full review. Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2016779 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
